Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_data_fred #2426

Closed
hidooki opened this issue Dec 4, 2012 · 4 comments
Closed

get_data_fred #2426

hidooki opened this issue Dec 4, 2012 · 4 comments
Labels
Enhancement IO Data IO issues that don't fit into a more specific label

Comments

@hidooki
Copy link

hidooki commented Dec 4, 2012

could you switch to calling urllib2.open (instead of urllib.open) in this function, so that it works seamlessly with http proxies?

@changhiskhan
Copy link
Contributor

Would you be interested in making a pull request? We'd welcome any/all contributions

@paulproteus
Copy link

As context:

  • Per http://docs.python.org/2/library/urllib2.html , urllib2 respects the http_proxy and HTTP_PROXY environment variables. Therefore, for people whose computers have those variables set, they typically want the Internet access to go via the proxy server, instead of directly to the Internet.
  • The get_data_fred function is defined in pandas/io/data.py
  • If you want to test this functionality, feel very free to ping me on the thread, and I will set you up with a proxy you can use to test this.

@paulproteus
Copy link

As far as I gather, adding an automated test for this would be fairly difficult, and unlikely to test exactly the right thing., so I believe it would not be required for this particular issue.

@jseabold
Copy link
Contributor

jseabold commented Mar 7, 2014

It looks like this is resolved in master.

@jseabold jseabold closed this as completed Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

No branches or pull requests

4 participants