Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simpler API for using resampling infrastructure to do general gropuby #2450

Closed
wesm opened this issue Dec 7, 2012 · 6 comments
Closed
Labels
Datetime Datetime data dtype Docs
Milestone

Comments

@wesm
Copy link
Member

wesm commented Dec 7, 2012

Using the TimeGrouper is both undocumented and not necessarily intended for average users. A cleaner, simpler API would be nice cc @dalejung related to bug in #2300
related to #3794

@dalejung
Copy link
Contributor

On first glance, changing resample(how=None) to return the GroupBy would work. Or just replicating the function without the how.

More generally, I'd say the resample stuff should be split up into the datetime64 binning and the bin grouping. That would allow exposing a generalized bingroupby that could take in edges, edges/labels, bool edge arrays.

That's it from the top of my head but I'm about to dive into some funky groupby stuff with Panels. So I'll be back

@jreback
Copy link
Contributor

jreback commented Sep 20, 2013

maybe let's leave this open in order to document TimeGrouper in groupby.rst?

@cpcloud
Copy link
Member

cpcloud commented Sep 20, 2013

yeah i removed my comment for that reason

@jreback
Copy link
Contributor

jreback commented Sep 20, 2013

@dalejung want to do a PR for this?

@dalejung
Copy link
Contributor

@jreback When I find time I'll gather some docs. I think I have some random notebooks I made to answer groupby/binning SO questions on nbviewer somewhere.

Though I'm not sure this addresses the issue. IIRC, the point was that TimeGrouper shouldn't be needed. Also, a GroupBy returned from TimeGrouper doesn't necessarily act exactly the same as a regular GroupBy. I'll have to poke around the internals again to remember.

@jreback
Copy link
Contributor

jreback commented Mar 15, 2014

closed by #6516

@jreback jreback closed this as completed Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Docs
Projects
None yet
Development

No branches or pull requests

4 participants