Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS: 0.24.x #24949

Closed
jreback opened this issue Jan 26, 2019 · 25 comments
Closed

RLS: 0.24.x #24949

jreback opened this issue Jan 26, 2019 · 25 comments
Labels
Admin Administrative tasks related to the pandas project Release
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jan 26, 2019

Tracking issue for 0.24.1

@jreback jreback added the Admin Administrative tasks related to the pandas project label Jan 26, 2019
@jreback jreback added this to the 0.24.1 milestone Jan 26, 2019
@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2019

@pandas-dev/pandas-core so it is very important to tag before you merge to a backport branch, otherwise the auto-backport-bot won't be triggered, e.g. we want to see something like #24951. Please make sure that these pass and then merge them (or you will need to manually fixup / merge to the backport branch).

@jorisvandenbossche
Copy link
Member

I created the branch, so from now on, if you label a PR with 0.24.1 before merging, a backport PR will be created automatically if possible (and if not possible, a label will be added).

@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2019

@jorisvandenbossche great thanks

@jorisvandenbossche
Copy link
Member

And since Jeff and I already had some discussion about it :)

IMO, we should not be backporting too much, but limit ourselves to regressions and important bug fixes.

Backporting any tiny doc fix / bug fix is simply a) more work, and b) gives a higher risk of also breaking something unneeded.

@jorisvandenbossche jorisvandenbossche added Admin Administrative tasks related to the pandas project Release and removed Admin Administrative tasks related to the pandas project labels Jan 26, 2019
@TomAugspurger
Copy link
Contributor

Thought on doing a 0.24.1 soonish? Tracking a few regressions

I'd like to include #24964 as well (probably not a regression in 0.24, but I think important to have working, since that's hurting our import times).

any others?

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2019

we need to wait a few weeks - not worth it to do for these minor things

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 27, 2019 via email

@h-vetinari
Copy link
Contributor

+0.5 for a fast release to fix the regressions before they got much chance to be relied on.

@jorisvandenbossche
Copy link
Member

+1 on doing quick releases with regression fixes, if it is not a lot of work.
Certainly for the intersection sort behaviour it would be good to do this as fast as possible

@TomAugspurger
Copy link
Contributor

I'd like to do a release in the next day or two. What are peoples thoughts? (I'll be busy next week, and unable to do the release myself. Others could, but I think getting a release out soon with the fixes for iteritems and the index setops is important).

Right now we have a decent number of issues on the 0.24.1 milestone, which I'm going through.

@jorisvandenbossche
Copy link
Member

I think only the regressions + the setops default change that are in the 0.24.1 milestone are important. +1 to do a release shortly.

@TomAugspurger
Copy link
Contributor

I'd like to do a release tonight if possible, with the following issues resolved

Any objections? Any other blockers?

@TomAugspurger
Copy link
Contributor

Tagging in about 5 hours from now.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 3, 2019

Waiting on #25085 to pass CI, then merging, back porting that, and tagging.

@jorisvandenbossche
Copy link
Member

@TomAugspurger Thanks a lot for the release!

One thing I noticed: due to the way we do the backporting now, the actual contributors don't get acknowledged: http://pandas.pydata.org/pandas-docs/version/0.24.1/whatsnew/v0.24.1.html. That section is quite useless/misleading now, so I would either update it manually or remove it.
In general, I think it could be solved by the bot using co-authors: scientific-python/MeeseeksDev#35

@jorisvandenbossche jorisvandenbossche changed the title RLS: 0.24.1 RLS: 0.24.x Feb 4, 2019
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.24.1, 0.24.2 Feb 4, 2019
@jorisvandenbossche
Copy link
Member

(repurposed this issue for a potential next 0.24.2)

@jorisvandenbossche
Copy link
Member

We already have a nice set of changes in 0.24.x, so shall we try to do a 0.24.2 release this week?

I have a little bit of time to look at some of the remaining open issues, but not that much. @TomAugspurger would you have a bandwidth to do a release? Otherwise I might be able to do early next week.

For the remaining open issues, I would certainly try to fix #25193 (the pip install problem), and some of the others seem to have a relatively straightforward fix (eg #25077, #25403).

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 4, 2019 via email

@jorisvandenbossche
Copy link
Member

Will be tagging 0.24.2 this afternoon (trying out the release scripts now)

@jorisvandenbossche
Copy link
Member

MacWheels tests are failing: https://travis-ci.org/MacPython/pandas-wheels/builds/505474702 (on python 3.6 a stata failure, and on python 2.7 numpy ufunc tests).
I am in a workshop during the day, so if somebody has time to look at it, certainly welcome (otherwise I will look at it this evening).

@simonjayhawkins
Copy link
Member

on python 2.7 numpy ufunc tests

#25186 fixes

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 13, 2019

Picking up the remaining release items now.

TODO:

Other

@simonjayhawkins
Copy link
Member

@TomAugspurger #25186 only for the numpy ufunc. there is still the stata issue.

@TomAugspurger
Copy link
Contributor

Thanks. Still investigating, but it's possibly a flaky test: #25707

@jorisvandenbossche
Copy link
Member

All wheels are uploaded, and website symlink is changed.

@jreback jreback closed this as completed Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project Release
Projects
None yet
Development

No branches or pull requests

5 participants