Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS: 0.25.0 #24950

Closed
jreback opened this issue Jan 26, 2019 · 32 comments
Closed

RLS: 0.25.0 #24950

jreback opened this issue Jan 26, 2019 · 32 comments
Labels
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jan 26, 2019

Tracking issue for 0.25.0

@jreback jreback added the Admin Administrative tasks related to the pandas project label Jan 26, 2019
@jreback jreback added this to the 0.25.0 milestone Jan 26, 2019
@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2019

@pandas-dev/pandas-core

as we briefly discussed before, we need to be pretty circumspect about merging even to master changes that are not backportable to 0.24.x, prob for a little while. Small changes ok, but sweeping reorgs just make backporting much more difficult (as may need to go thru potentially a lot of effort to backport). So am going to suggest that we hold off on 'bigger' things until 0.24.1 is out.

  • this means don't remove any PY2 removal stuff quite yet.
  • we may need to keep merging master on soon to be merged PRs, so the backlog may grow.
  • bug fixes, by all means, sometimes this may mean narrowing the scope of a bug fix though (meaning that if the 'right' way to do it involves a fairly big reorg).

@jorisvandenbossche jorisvandenbossche added Release and removed Admin Administrative tasks related to the pandas project labels Jan 26, 2019
@jbrockmendel
Copy link
Member

Do we have any major goals for 0.25.0?

@jreback
Copy link
Contributor Author

jreback commented Jan 28, 2019

  • deprecate remaining items on the list
  • remove PY2

@h-vetinari
Copy link
Contributor

h-vetinari commented Jan 28, 2019

I think one of the key points is still to decide on a policy for dealing with breaking changes, both for 0.25/1.0 and after.

There's still a bunch of inconsistencies that we'd be locking in for 1.0, and even more so if we'd be doing actual SemVer afterwards - changing a None to a np.nan somewhere would then already count as breaking).

This list is obviously not exhaustive. Pandas is certainly very mature by now, but IMO not consistent enough to do SemVer (otherwise every release would be major).

Maybe numpy-style rolling deprecations (as we've been doing as well) would be less restrictive to actually fixing some of these issues (it's worth noting that on the numpy side, it will still take monumental determination and effort to actually fix some very longstanding issues for an eventual 2.0)

There's much smaller fish I'd like to fry as well, but all of which are breaking in some way.

TL;DR: most bigger PRs are breaking from the point of SemVer. A policy of zero breaking changes until 1.0 will probably mean little development.

@stonebig
Copy link
Contributor

stonebig commented May 3, 2019

What is the likely pandas-0.25.0 release date ?

@jorisvandenbossche
Copy link
Member

@stonebig we didn't really discuss in detail recently, but I think we still target to release somewhere in June (but no guarantees!)

@TomAugspurger
Copy link
Contributor

Are we on track for cutting an RC today? (my gut says "not quite").

I'm fixing up a few CI issues across pandas & dask right now. Will do a run through outstanding issues after that (I know I have the __array_ufunc__ PR at least).

@jreback
Copy link
Contributor Author

jreback commented Jul 1, 2019

yeah let’s get ci fixed and merge what we can
tomorrow

@jreback
Copy link
Contributor Author

jreback commented Jul 1, 2019

@jorisvandenbossche @TomAugspurger I am super busy today / tomorrow, so don't block on me for things and merge where you guys think appropriate. if you want me to specifically review something, pls ping.

@jorisvandenbossche
Copy link
Member

@jreback I would like to have your go for #17753

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 3, 2019

@pandas-dev/pandas-core I think #27095 is the last one for the RC.

I'll try to tag 0.25.0rc0 tonight (~5 hours from now).

LMK if there are any others that should go in.

@jorisvandenbossche
Copy link
Member

If we do #26043, I think should include that in the RC as well (but seems green apart from some code check)

@jreback
Copy link
Contributor Author

jreback commented Jul 3, 2019

I just pushed a patch for #26043 - hopefullly should be green soon.

@WillAyd
Copy link
Member

WillAyd commented Jul 3, 2019

If #25427 is mergeable would be good to get in before release

@jschendel
Copy link
Member

I just opened #27221; I've marked it as 0.25.0 but I'm not dead set on getting it into 0.25.0. No need to hold up the RC for it.

I have a couple other small Interval related things in mind that I want to work on in the next day, but same deal with not being dead set on 0.25.0. They should be relatively self-contained, so it might be fine to merge them as part of 0.25.0 after the RC but before the official release? Otherwise perfectly fine to push them to the next release.

@jbrockmendel
Copy link
Member

Is it too late to remove _IXIndexer before for 0.25.0? I'm finding some ugly code in internals is only reached via ix

@TomAugspurger
Copy link
Contributor

Feels a bit late. I'd like to tag the RC soon (next hour if possible).

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jul 4, 2019

Is it too late to remove _IXIndexer before for 0.25.0? I'm finding some ugly code in internals is only reached via ix

We only changed the warning to FutureWarning this release, so it in any case only to remove for 1.0 I think.

@jschendel for the interval ones, if they are new features that don't really touch existing behaviours, we can maybe merge some after the RC

@jorisvandenbossche
Copy link
Member

OK, black went in, so all ready to tag I think (I am offline now)

@TomAugspurger
Copy link
Contributor

@pandas-dev/pandas-core tagged 0.25.0rc0.

Binary packages are building at conda-forge/pandas-feedstock#64 and MacPython/pandas-wheels#54.

Building the docs. Will push them tomorrow morning and send out the announcement.

@jorisvandenbossche
Copy link
Member

There is a lot of activity (which is great), but since we put a RC out, I think we should be a bit careful with merging a lot of refactoring / cleaning PRs (they always have a small risk of breaking something that was not covered) or further PRs removing things (I just commented on #27377).

Instead of holding up some PRs, we could also already branch 0.25.x and specifically pick PRs to backport? (with the bot that goes rather smooth).

@jreback
Copy link
Contributor Author

jreback commented Jul 13, 2019

#27288 needs to be fixed
and #27267 is ready otherwise we should just release

the rc don’t have much testing compared with an actual release

@bashtage
Copy link
Contributor

Any idea about the timeframe for 0.25? statsmodels needs a point release I think for 0.25 and so it would be good to have it ready to go when pandas releases.

@TomAugspurger
Copy link
Contributor

@bashtage will let you know later today.


@jreback @jorisvandenbossche I'm back online today, getting caught up. I recall seeing a message about an API breaking change being merged in the RC, so we'll need to revert that or have a second RC? I'll post when I find what I'm talking about.

@jreback
Copy link
Contributor Author

jreback commented Jul 15, 2019

I recall seeing a message about an API breaking change being merged in the RC

nothing significant has been merged, so I think the release is pretty good (ex my comments above).

@WillAyd
Copy link
Member

WillAyd commented Jul 15, 2019

Maybe want to revert #27252 - I can try to get to that in next day or so but if someone else wants to tackle in the meantime wouldn't mind

@jreback
Copy link
Contributor Author

jreback commented Jul 17, 2019

@TomAugspurger ok just a couple issues that are on for 0.25 (the viz things), other than that lgtm.

@WillAyd
Copy link
Member

WillAyd commented Jul 18, 2019

As of now there are two plotting issues still tagged for 0.25 #27152 and #26747 - are these still valid? I don't see any open PRs referencing them so OK to remove from the milestone?

There's one open PR #27384 but looks to be near completion; any objection to calling it a release after that gets merged?

@TomAugspurger
Copy link
Contributor

I merged #27384

@WillAyd do you want to make a PR fixing the date on the 0.25 release note?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 18, 2019

I think the plotting issues are OK to push (and #27152 can maybe be closed. Need to check).

@WillAyd
Copy link
Member

WillAyd commented Jul 19, 2019

Released!

@WillAyd WillAyd closed this as completed Jul 19, 2019
@jreback
Copy link
Contributor Author

jreback commented Jul 19, 2019

thanks for the release @WillAyd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants