Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build failing because of gbq testing #25910

Closed
jreback opened this issue Mar 28, 2019 · 7 comments · Fixed by #25912
Closed

CI: build failing because of gbq testing #25910

jreback opened this issue Mar 28, 2019 · 7 comments · Fixed by #25912
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 28, 2019

see #25554 (comment)

added back the gbq dep and this is now failing.

@jreback jreback added CI Continuous Integration IO Google Dependencies Required and optional dependencies labels Mar 28, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 28, 2019
@jreback
Copy link
Contributor Author

jreback commented Mar 28, 2019

cc @h-vetinari @tswast

@h-vetinari
Copy link
Contributor

Seems to be conda-forge/pandas-gbq-feedstock#18, compare failed job.

    def _test_google_api_imports():
    
        try:
            import pydata_google_auth
        except ImportError as ex:
            raise ImportError(
>               "pandas-gbq requires pydata-google-auth: {0}".format(ex)
            )
E           ImportError: pandas-gbq requires pydata-google-auth: No module named 'pydata_google_auth'

Note that pandas-gbq wasn't tested anywhere in the CI between #24942 was merged and now (after #25554). Seems we're still getting the old recipe somehow, because this is failing on the unpinned build. Simplest solution is to add pydata-google-auth to conda deps for the time being.

@jreback
Copy link
Contributor Author

jreback commented Mar 28, 2019

what does the recipe have to do with this? we are installing the released package

@h-vetinari
Copy link
Contributor

The error is caused by a missing dependency (cf. ImportError) - exactly the one that was missing in the recipe. This dependency can be satisfied with conda, so that's IMO a better work-around than removing pandas-gbq from testing - this is what I've done in #25912.

@tswast
Copy link
Contributor

tswast commented Mar 28, 2019

The condo package for pandas-gbq 0.8.0 is busted. Sorry about that. I fixed this issue in the second build of 0.9.0 in conda-forge/pandas-gbq-feedstock@4c9a987

@tswast
Copy link
Contributor

tswast commented Mar 28, 2019

Oh, except I see now that the build failed on that commit. I'll get a new build out soon.

@tswast
Copy link
Contributor

tswast commented Mar 28, 2019

Reran the conda-forge build for pandas-gbq-feedstock and now the fixed build 1 should actually be published now. https://anaconda.org/conda-forge/pandas-gbq/files?version=0.9.0 Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants