-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpydoc sphinx extension disabled. was: Docstring convention #3431
Comments
This is the numpy docstring standard parsed with sphinxext/numpydoc.py. I'd be strongly against doing away with it since it's the de facto standard across many packages and what many people have come to expect. It's much easier to look at vs. the examples you've posted assuming this is what I'd see at the interpreter. What do you mean it confuses sphinx and impedes automation? |
Thanks, I wasn't in on that. I think I unceremoniously kicked out numpydoc due to this: Could see no diff at the time, probably explains why sphinx is yelling a lot. The format seems to be harder to parse, that's what I meant by "impedes automation", |
Oh ok. It can be a real pain to get to zero warning docs builds the first time, if no one has been keeping up with it, but it's certainly possible. In my experience there's no such thing as a false positive warning. They all indicate some kind of formatting error which will show up in the built documentation. |
Pretty sure I screwed up the 0.11.0 documentation for all distros until 0.12 comes out. nice. e6aaca5: DOC: bring back numpydoc |
Luckily in my experience no one ever reads the documentation ;) |
well, maybe if you didn't use scary words like |
Feel free to add your voice to this "fun" discussion |
edit: totally misguided.
Sphinx has great support for method signature metadata in docstrings,
there are python standars for ReST docstrings, and tooling to leverage
and generate the docstrings.
In practice pandas uses an ad-hoc "visual" format for docstrings, whichconfuses sphinx and impedes automation.
Major cleanup all over.
http://www.python.org/dev/peps/pep-0257/
http://www.python.org/dev/peps/pep-0287/
edit: numpydoc is in use by pandas, unbeknownst to me previously.
#2916, #3422
Bad:
Better:
Much Better:
The text was updated successfully, but these errors were encountered: