-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Set numeric_only=True in aggregations #34521
Comments
There should already be some issues about this, eg I remember @jbrockmendel recently raising this as well, and I suspect some older issues as well |
The one I remembered is #28900, I think this can be closed as a duplicate? |
It's a little bit different. That PR is about removing the kwarg whereas this is about changing the default value The former would encapsulate the latter but we may want to do in steps instead of outright removal |
OK, that's right, but I would still propose to use the other issue for that discussion? As in the end it is a single discussion about what to do with this keyword: keep as is, change default, or fully remove. It are not really separate discussions? |
Sure that works just as well |
I've noticed that I make this mistake quite often:
Getting
111
as a result in column a is harmless in this example, but actually quite annoying in most real life use cases where it can produce exceedingly large strings that exhaust memory or tie up the interpreter.The
numeric_only
argument gets around this issue:Though I'm curious if this should really be the default
The text was updated successfully, but these errors were encountered: