RLS: 1.2.1 #38721
Comments
|
current status: 8 open regressions milestoned 1.2.1, 2 with open PRs (#38752 is a actually a regression in 1.1 but is milestoned 1.2.1) |
|
status update... a week away from scheduled release. 9 open regressions milestoned 1.2.1, 1 with open PR #38980 #38969 is effectively a duplicate of #38947 #38851 maybe tricky to fix so maybe best to revert cleanup for 1.2.1. #38851 (comment) #38946 is maybe not a priority so could remove from milestone #38946 (comment) #38752 is a actually a regression in 1.1 but is milestoned 1.2.1 |
|
ok, can certainly try on these. but let's just do a time release. whatever we have is fine. |
yep, certainly on the patch releases (except the final in the series) a calendar based release schedule is fine. |
|
we've got the blocker label on #38787, should maybe discuss this on this week's dev call. cc @jorisvandenbossche @mroeschke |
|
although need not block, can revert backport, tag release, and re-apply backport if not resolved. |
Yes, that would be a good topic to discuss (although don't know if Matt will be there). But I will try to look again at the issue and post my thoughts there. |
|
I believe I can make the dev call this Wednesday to discuss #38787 |
|
in the dev meeting notes for the release we have
@jorisvandenbossche I believe you suggested this. I think that we should not yet revert until have investigated the issues further. 1.2.2 is scheduled for February 07, 2021 (3 weeks) current status: 9 open regressions milestoned 1.2.1 5 linked to the visualization issue #39126, #38969, #38947, #38865 and #38736 #39184 requires further discussion/agreement on preferred course of action #39115 and #39168 have open PRs #38946 is not a priority for 1.2.1 |
from my limited understanding of the changes in that PR, I'm leaning towards the revert option. If we do revert (for 1.2.1), should also have tests to prevent future regression. I'll open a PR for the revert, just in case, but won't be adding regression tests, so would need to leave the issues open with a 'needs tests' label. |
|
I think that would be OK to just do the revert now, and add tests in follow-up PRs. |
|
4 open PRs milestoned 1.2.1. These need to be merged or moved off milestone before we start the release process https://github.com/pandas-dev/pandas/pulls?q=is%3Apr+is%3Aopen+milestone%3A1.2.1 |
|
#39239 is obviously a last minute change, but if people agree on the deprecation, I think we should try to include it. I think my patch is relatively safe, since converting the input to numpy arrays (what I am doing now manually as fallback) is what happened before adding If I can get some review on the PR, we should be able to merge it in the afternoon |
|
let's move them all off 1.2.1 last minute changes are always a bad idea |
|
final pre-release checklist
|
|
@simonjayhawkins do you have time to give #39239 a review? (Tom mentioned before he was OK with the change if we would be able to do it soon: #39184 (comment)) |
|
I've given it a quick once over, I'll look again in more detail. |
|
@simonjayhawkins I moved the excel regressions to the 1.2.1 milestone. So with that, the queue is clear, and only waiting on CI to pass on the 1.2.x branch I think (I merged the backport) |
|
final pre-release checklist
|
|
starting release now.
|
|
Thanks for the release @simonjayhawkins ! |
|
thanks @simonjayhawkins ! |
Tracking issue for the 1.2.1 release.
https://github.com/pandas-dev/pandas/milestone/81
Currently scheduled for January 18, 2021 (date flexible on severity of regressions)
List of open regressions: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ARegression
The text was updated successfully, but these errors were encountered: