Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: unify the replace API #4118

Closed
cpcloud opened this issue Jul 3, 2013 · 9 comments
Closed

ENH: unify the replace API #4118

cpcloud opened this issue Jul 3, 2013 · 9 comments
Labels
API Design Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone

Comments

@cpcloud
Copy link
Member

cpcloud commented Jul 3, 2013

Currently DataFrame and Series do slightly different things when their respective replace methods are called and accept slightly different arguments. This should be rectified in 0.13.

@jreback
Copy link
Contributor

jreback commented Aug 16, 2013

I believe this is closable now.... after #3482 maybe need to add some more tests though?

@cpcloud
Copy link
Member Author

cpcloud commented Aug 16, 2013

yep i think some regex tests are in order....might be a little while before i can get to them tho

@jreback
Copy link
Contributor

jreback commented Aug 16, 2013

maybe should move tests like this to tests/test_generic.py? ?

@cpcloud
Copy link
Member Author

cpcloud commented Aug 16, 2013

yep and probably any tests that fit that bill (no idea how many that is....)

@jreback
Copy link
Contributor

jreback commented Aug 16, 2013

let me add that to post series2

@jreback
Copy link
Contributor

jreback commented Aug 21, 2013

FYI I created tests/test_generic.py for at some point add these tests

@cpcloud
Copy link
Member Author

cpcloud commented Aug 21, 2013

nice

@jreback
Copy link
Contributor

jreback commented Sep 27, 2013

I think this is closed? @cpcloud

@cpcloud
Copy link
Member Author

cpcloud commented Sep 27, 2013

everything except for equivalent tests, but those are in #4324

@cpcloud cpcloud closed this as completed Sep 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

No branches or pull requests

2 participants