Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Build documentation broken after jinja2 update to 3.0 #41450

Closed
phofl opened this issue May 13, 2021 · 4 comments · Fixed by #41913
Closed

CI: Build documentation broken after jinja2 update to 3.0 #41450

phofl opened this issue May 13, 2021 · 4 comments · Fixed by #41913
Labels
CI Continuous Integration Dependencies Required and optional dependencies Upstream issue Issue related to pandas dependency
Milestone
1.3

Comments

@phofl
Copy link
Member

phofl commented May 13, 2021 •
edited
Loading

Looks like an upgrade broke our doc build.

Successful build:
https://github.com/pandas-dev/pandas/runs/2567593238

Broken build:
https://github.com/pandas-dev/pandas/pull/41444/checks?check_run_id=2573993166

This occurs in more than one pr, so not related to changes in the prs

Full version diff:

       packages                      version_now              version_previous
70        boto3                      1.17.72                      1.17.71
71     botocore                      1.20.72                      1.20.71
86        click                        8.0.0                        7.1.2
141   gitpython                       3.1.16                       3.1.15
203      jinja2                        3.0.0                       2.11.3
327  markupsafe                        2.0.0                        1.1.1
343        moto                        2.0.7                        2.0.5
403      pandas  1.3.0.dev0+1607.g0a3a7c7f5d  1.3.0.dev0+1605.g4ec6925c19
591   terminado                        0.9.5                        0.9.4
661         NaN                          NaN                            #
@phofl phofl added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration Dependencies Required and optional dependencies and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels May 13, 2021
@phofl phofl mentioned this issue May 13, 2021
Merged
4 tasks
@jreback
Copy link
Contributor

jreback commented May 13, 2021

this has to be the sphinx update. pin <4.0.0 for now

@phofl phofl mentioned this issue May 13, 2021
Merged
1 task
@phofl
Copy link
Member Author

phofl commented May 13, 2021

I think this is related to the jinja2 upgrade to 3.0. Sphinx is still 3.5.4. Pinned this in the related pr

@phofl phofl changed the title CI: Build documentation broken after version update CI: Build documentation broken after jinja2 update to 3.0 May 13, 2021
@jorisvandenbossche
Copy link
Member

The cause for the doc failure is due to a nbsphinx / jinja interaction: spatialaudio/nbsphinx#563

@lithomas1 lithomas1 added this to the 1.3 milestone May 14, 2021
@lithomas1 lithomas1 added the Upstream issue Issue related to pandas dependency label May 21, 2021
@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone May 25, 2021
@simonjayhawkins
Copy link
Member

removed the milestone, I assume the current pin is ok for the release?

@lithomas1 lithomas1 mentioned this issue Jun 9, 2021
Merged
@lithomas1 lithomas1 added this to the 1.3 milestone Jun 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies Upstream issue Issue related to pandas dependency
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Revert "CI: Pin jinja2 to version lower than 3.0" lithomas1/pandas
5 participants
@jreback @jorisvandenbossche @simonjayhawkins @lithomas1 @phofl