Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLS: 1.3.5 #44080

Closed
simonjayhawkins opened this issue Oct 18, 2021 · 12 comments
Closed

RLS: 1.3.5 #44080

simonjayhawkins opened this issue Oct 18, 2021 · 12 comments
Labels
Release
Milestone
1.3.5

Comments

@simonjayhawkins
Copy link
Member

Tracking issue for the 1.3.5 release.

Currently scheduled for November 28, 2021. (This is a couple of weeks before 1.4.0rc0)

The patch releases are on a calendar schedule of 3-3-4-5-6 weeks, however if 1.3.5 is the last in the 1.3.x series, we would delay to resolve any outstanding issues if necessary. But ideally get it done before the 1.4 release candidate)

https://github.com/pandas-dev/pandas/milestone/91

List of open regressions: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ARegression

cc @pandas-dev/pandas-core @pandas-dev/pandas-triage
@simonjayhawkins simonjayhawkins added this to the 1.3.5 milestone Oct 18, 2021
@simonjayhawkins
Copy link
Member Author

10 days away from the scheduled release of 1.3.5 and quite a few open issues with no PRs in the pipeline to fix.

1.3.5 is planned to be the last in the 1.3.x series of releases, so ideally we would want all these issues closed off before 1.3.5 release rather than moving them onto 1.4.x.

Additional sets of eyeballs on the open issues very welcome.

@jreback
Copy link
Contributor

jreback commented Nov 18, 2021

we should be very selective on backport at this point

@simonjayhawkins
Copy link
Member Author

Agreed, If we can get consensus on the no action issues we could probably whittle down the list a bit.

@simonjayhawkins
Copy link
Member Author

if 1.3.5 is the last in the 1.3.x series, we would delay to resolve any outstanding issues if necessary. But ideally get it done before the 1.4 release candidate)

since this comment, it was discussed at the dev meeting that the 1.4 release would be in early January to avoid the holiday season. The rc period of 2 weeks can either be extended, i.e. keep 2 weeks before the original 1.4 provisional date of December 31, 2021 or moved too. We probably want to extend the rc period to avoid the rc failing too close to the holiday season.

Will not be releasing 1.3.5 while there are still open issues milestoned 1.3.5 and since the last patch release is arguably the most important release in the series will not be moving these issues off the milestone without due consideration.

There are a couple for which the fixes have been identified and discussed and can probably be closed off with a PR #42549 and #43329

In #42659 the issue is clear but a fix not yet identified.

There are a couple without any meaningful discussion/investigation #42915 and #42376

#42437 is maybe just a doc issue for the EA interface and a no action for 1.3.5

That leaves #43206, #43351, #42747 and #43222 where the issues are less clear cut and appropriate action has not yet been decided/agreed.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

commented on most
i don't think any of these block 1.3.x except maybe the rolling cov one (if it's easy)

@simonjayhawkins
Copy link
Member Author

Thanks Jeff. Looks like we can probably release soon, maybe next couple of days, but still have some time available before 1.4.0rc0 if needed.

@jbrockmendel
Copy link
Member

@simonjayhawkins LMK if there's anything you'd like me to prioritize over the next few days. (best by email so it doesn't get lost in flood of GH pings)

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 3, 2021 •
edited
Loading

i don't think any of these block 1.3.x except maybe the rolling cov one (if it's easy)

I've labelled #42915 as blocker for now pending further investigation.

If no objections will move the other issues off the milestone with the exception of #43329 which just needs a PR close.

@simonjayhawkins
Copy link
Member Author

any objections to releasing tomorrow?

@jreback
Copy link
Contributor

jreback commented Dec 11, 2021

no let's do it

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 12, 2021 •
edited
Loading

pre-release checklist

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 12, 2021 •
edited
Loading

starting release now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
1.3.5
Development

No branches or pull requests
3 participants
@jreback @jbrockmendel @simonjayhawkins