Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix xfail for git component of pd.show_version tests on 32 bit builds #46856

Closed
mroeschke opened this issue Apr 24, 2022 · 8 comments · Fixed by MacPython/pandas-wheels#183
Labels
32bit 32-bit systems Blocker Blocking issue or pull request for an upcoming release Testing pandas testing functions or related to the test suite
Milestone

Comments

@mroeschke
Copy link
Member

mroeschke commented Apr 24, 2022

Two tests were xfailed in this PR that suddenly failed. #46842

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite 32bit 32-bit systems labels Apr 24, 2022
@mroeschke mroeschke changed the title TST: Fix xfail for git pd.show_version tests on 32 bit builds TST: Fix xfail for git component of pd.show_version tests on 32 bit builds Apr 24, 2022
@jbrockmendel
Copy link
Member

spitballing: i wonder if we can record when xfail(strict=False) tests xpass to try to track down patterns in the relevant conditions

@mroeschke
Copy link
Member Author

Yeah possibly we could have an automation flow that reads the test-data.xml and when there are xpasses in the logs we can write to an issue

@simonjayhawkins
Copy link
Member

These tests are also failing on pandas-wheels nightly linux builds https://dev.azure.com/pandas-dev/pandas-wheels/_build?definitionId=3&_a=summary

@simonjayhawkins
Copy link
Member

skipped on pandas-wheels for now MacPython/pandas-wheels#182 so that nightly builds for Linux are uploaded to https://anaconda.org/scipy-wheels-nightly/pandas/files

@lithomas1 lithomas1 added the Blocker Blocking issue or pull request for an upcoming release label May 31, 2022
@lithomas1
Copy link
Member

Marking as blocker for release. The wheel filenames will be messed up if this is not fixed(this may prevent pypi uploads).

@simonjayhawkins
Copy link
Member

The wheel filenames will be messed up

Thanks @lithomas1 the nightlies did upload but the the wrong prefix pandas-0+unknown- instead of pandas-1.5.0.dev0+849.g3bf2cb1b22- so were probably of no use. (we may need to delete these from the server)

@lithomas1
Copy link
Member

(we may need to delete these from the server)

@simonjayhawkins Can you do this? I have no permissions whatsoever outside of this repo.

Nightlies are sadly still broken.
On Windows, the failures are because tzdata is a required dependency when testing, because of a bug here.

pandas/pandas/conftest.py

Lines 1219 to 1220 in 259a15c

if zoneinfo is not None:
TIMEZONES.extend([zoneinfo.ZoneInfo("US/Pacific"), zoneinfo.ZoneInfo("UTC")])

We need to create a dummy ZoneInfo object and check to see if that works as zoneinfo will not raise if tzdata is missing on import, only when creating the ZoneInfo object.

tzdata should also probably be added to the optional dependencies list in the docs and in pandas/compat/_optional.py.
I dunno which minimum version we should support though.

cc @jbrockmendel (who added zoneinfo support)

@jbrockmendel
Copy link
Member

tzdata should also probably be added to the optional dependencies

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems Blocker Blocking issue or pull request for an upcoming release Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants