Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Consistency in prefix / prefix_sep #8141

Open
TomAugspurger opened this issue Aug 29, 2014 · 2 comments
Open

API: Consistency in prefix / prefix_sep #8141

TomAugspurger opened this issue Aug 29, 2014 · 2 comments
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement

Comments

@TomAugspurger
Copy link
Contributor

Currently get_dummies has both prefix and prefix_sep parameters. This is inconsistent with the rest of pandas prefix / suffix arguments that have you included the separator in the pre/suffix.

  • read_csv
  • join
    probably others.

We should add a warning to get_dummies to have users change prefix_sep to '' and include the separators in prefix.

@jreback
Copy link
Contributor

jreback commented Aug 29, 2014

I meant you should not include prefix_sep in get_dummies at all (was it their previously?)

@TomAugspurger
Copy link
Contributor Author

Yep it was already there. The only change I made to the function signature was adding the categorical_variables keyword.

@jreback jreback added this to the 0.15.1 milestone Aug 29, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@datapythonista datapythonista modified the milestones: Contributions Welcome, Someday Jul 8, 2018
@jbrockmendel jbrockmendel added the API - Consistency Internal Consistency of API/Behavior label Dec 26, 2019
@mroeschke mroeschke added Enhancement and removed Compat pandas objects compatability with Numpy or Python functions Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode good first issue labels Apr 10, 2020
@mroeschke mroeschke removed this from the Someday milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants