Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: concat of 2 Series categories does not preserve category dtype #8641

Closed
jreback opened this issue Oct 26, 2014 · 2 comments · Fixed by #8714
Closed

ERR: concat of 2 Series categories does not preserve category dtype #8641

jreback opened this issue Oct 26, 2014 · 2 comments · Fixed by #8714
Labels
Bug Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Oct 26, 2014

xref #8640

As this is inconcistent with how DataFrame concat's work (its a different code-path), so needs updating

s = Series(list('abc'),dtype='category')
s2 = Series(list('abd'),dtype='category')

# this should raise
pd.concat([s,s2])

# this should be a category
pd.concat([s,s])
@jreback jreback added Bug Error Reporting Incorrect or improved errors from pandas Categorical Categorical Data Type labels Oct 26, 2014
@jreback jreback added this to the 0.15.1 milestone Oct 26, 2014
@springcoil
Copy link
Contributor

Any remarks on how big of a job this is? Is it a good first PR because I might have a look then.

@jreback
Copy link
Contributor Author

jreback commented Oct 27, 2014

ahh, this is very straightforward actually, just a small change. have a look if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants