Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Slicing subclasses of SparseDataFrames. #13787

Closed
wants to merge 12 commits into from
Closed

BUG: Slicing subclasses of SparseDataFrames. #13787

wants to merge 12 commits into from

Commits on Aug 1, 2016

  1. BUG: Fix slicing subclasses of SparseDataFrames. 

    Use proper subclassing behaviour so subclasses work properly: this fixes
an issue where a multi-element slice of a subclass of SparseDataFrame
returned the SparseDataFrame type instead of the subclass type.
    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    ddc2874 View commit details
    Browse the repository at this point in the history

  2. Formatting changes.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    7c10bb5 View commit details
    Browse the repository at this point in the history

  3. Add type checks to sparse object comparisons.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    cdb7c8c View commit details
    Browse the repository at this point in the history

  4. Modify the new test to compare complete objects.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    140e4ad View commit details
    Browse the repository at this point in the history

  5. Use _constructor when instantiating SparseDataFrames. 

    This should fix subclassing issues.
    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    1d4e9da View commit details
    Browse the repository at this point in the history

  6. Lint corrections.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    4e31303 View commit details
    Browse the repository at this point in the history

  7. Further SparseSeries subclass fixes.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    0387303 View commit details
    Browse the repository at this point in the history

  8. Proper test parameter override, travis soothing.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    d73ec68 View commit details
    Browse the repository at this point in the history

  9. Additional sparse subclass tests.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    436a06d View commit details
    Browse the repository at this point in the history

  10. Properer test assertion override.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    0b74034 View commit details
    Browse the repository at this point in the history

  11. Changed the override from 0.17.0 to 0.12.0.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    8d2ff79 View commit details
    Browse the repository at this point in the history

  12. Add a whatsnew note.

    @sstanovnik
    sstanovnik committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    a7fb24f View commit details
    Browse the repository at this point in the history