TST: Add test decorators for redirecting stdout and stderr #15952

gfyoung · 2017-04-08T20:00:58Z

Add testing decorators for redirecting stdout and stderr.

codecov · 2017-04-08T20:55:29Z

Codecov Report

Merging #15952 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15952      +/-   ##
==========================================
+ Coverage   90.99%      91%   +0.01%     
==========================================
  Files         145      145              
  Lines       49570    49576       +6     
==========================================
+ Hits        45106    45118      +12     
+ Misses       4464     4458       -6

Flag	Coverage Δ
#multiple	`88.77% <100%> (+0.01%)`	⬆️
#single	`40.57% <73.33%> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
pandas/util/decorators.py	`65.3% <100%> (+3.04%)`	⬆️
pandas/util/testing.py	`81.13% <100%> (+0.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f5851...9edafd9. Read the comment docs.

codecov · 2017-04-08T20:55:33Z

Codecov Report

Merging #15952 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15952      +/-   ##
==========================================
+ Coverage   90.99%      91%   +0.01%     
==========================================
  Files         145      145              
  Lines       49570    49576       +6     
==========================================
+ Hits        45106    45118      +12     
+ Misses       4464     4458       -6

Flag	Coverage Δ
#multiple	`88.77% <100%> (+0.01%)`	⬆️
#single	`40.57% <73.33%> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
pandas/util/decorators.py	`65.3% <100%> (+3.04%)`	⬆️
pandas/util/testing.py	`81.13% <100%> (+0.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aef74f...82e11c1. Read the comment docs.

jreback · 2017-04-08T20:59:22Z

pandas/tests/io/parser/common.py

+
+        # Engines are verbose in different ways.
+        if self.engine == 'c':
+            self.assertIn('Tokenization took:', output)


while you are at it, can you use pytest idioms here, e.g. self.assertIn -> assert output in ......

Sure thing. Done.

jreback · 2017-04-08T20:59:30Z

pandas/tests/io/parser/common.py

+            self.assertIn('Parser memory cleanup took:', output)
+        else:  # Python engine
+            exp = 'Filled 1 NA values in column a\n'
+            self.assertEqual(output, exp)


assert output == exp

jreback · 2017-04-08T20:59:46Z

pandas/tests/io/test_sql.py

-                              con=self.conn)
-        finally:
-            sys.stdout = sys.__stdout__
+


use pytest.raises

jreback · 2017-04-08T21:00:26Z

pandas/util/testing.py

+    """
+    Capture stdout in a buffer so that it can be checked
+    (or suppressed) during testing.
+    """


can you say this is a decorator, and show how to use it. (same as on capture_stderr).

also move these near the other routine which maniuplates stdout (about encoding IIRC).

jreback · 2017-04-08T21:58:41Z

thanks @gfyoung !

gfyoung force-pushed the stderr-test-fixture branch from c256e1d to 9edafd9 Compare April 8, 2017 20:03

gfyoung changed the title ~~TST: Add test fixtures for redirecting stdout and stderr~~ TST: Add test decorators for redirecting stdout and stderr Apr 8, 2017

jreback added the Testing pandas testing functions or related to the test suite label Apr 8, 2017

jreback added this to the 0.20.0 milestone Apr 8, 2017

jreback approved these changes Apr 8, 2017

View reviewed changes

gfyoung force-pushed the stderr-test-fixture branch 2 times, most recently from f060903 to c4b934f Compare April 8, 2017 21:22

TST: Add decorators for redirecting stdout/err

82e11c1

gfyoung force-pushed the stderr-test-fixture branch from c4b934f to 82e11c1 Compare April 8, 2017 21:22

jreback merged commit 4e38396 into pandas-dev:master Apr 8, 2017

gfyoung deleted the stderr-test-fixture branch April 8, 2017 22:01

This was referenced Apr 13, 2017

DEPR: Deprecate generic timestamp dtypes #15987

Merged

TST: Converting to Pytest Idiom #15990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Add test decorators for redirecting stdout and stderr #15952

TST: Add test decorators for redirecting stdout and stderr #15952

gfyoung commented Apr 8, 2017

codecov bot commented Apr 8, 2017

codecov bot commented Apr 8, 2017 •

edited

Loading

jreback Apr 8, 2017

gfyoung Apr 8, 2017

jreback Apr 8, 2017

gfyoung Apr 8, 2017

jreback Apr 8, 2017

gfyoung Apr 8, 2017

jreback Apr 8, 2017

jreback Apr 8, 2017

gfyoung Apr 8, 2017

jreback commented Apr 8, 2017

TST: Add test decorators for redirecting stdout and stderr #15952

TST: Add test decorators for redirecting stdout and stderr #15952

Conversation

gfyoung commented Apr 8, 2017

codecov bot commented Apr 8, 2017

Codecov Report

codecov bot commented Apr 8, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Apr 8, 2017

codecov bot commented Apr 8, 2017 •

edited

Loading