Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove tm.assertNotIsInstance from testing #16061

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 20, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #16061 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16061      +/-   ##
==========================================
+ Coverage   90.82%   90.84%   +0.02%     
==========================================
  Files         159      159              
  Lines       50794    50791       -3     
==========================================
+ Hits        46134    46143       +9     
+ Misses       4660     4648      -12
Flag Coverage Δ
#multiple 88.62% <ø> (+0.02%) ⬆️
#single 40.36% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.76% <ø> (-0.06%) ⬇️
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b52b12...762dde9. Read the comment docs.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Apr 20, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 20, 2017
@jreback jreback merged commit b9cb3fe into pandas-dev:master Apr 20, 2017
@jreback
Copy link
Contributor

jreback commented Apr 20, 2017

thanks!

keem em coming!

analyticalmonk pushed a commit to analyticalmonk/pandas that referenced this pull request Apr 20, 2017
@gfyoung gfyoung deleted the assertNotIsInstance-remove branch April 20, 2017 14:47
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants