Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove self.assertAlmostEqual from testing #16183

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 1, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented May 1, 2017

Codecov Report

Merging #16183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16183   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         162      162           
  Lines       50827    50827           
=======================================
  Hits        46184    46184           
  Misses       4643     4643
Flag Coverage Δ
#multiple 88.64% <ø> (ø) ⬆️
#single 40.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d647045...8b8af9b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 1, 2017

Codecov Report

Merging #16183 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16183      +/-   ##
==========================================
- Coverage   90.88%   90.86%   -0.03%     
==========================================
  Files         162      162              
  Lines       50827    50827              
==========================================
- Hits        46195    46184      -11     
- Misses       4632     4643      +11
Flag Coverage Δ
#multiple 88.64% <ø> (-0.03%) ⬇️
#single 40.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.07% <ø> (ø) ⬆️
pandas/plotting/_converter.py 63.54% <0%> (-1.82%) ⬇️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096e215...0dd458e. Read the comment docs.

@gfyoung gfyoung force-pushed the assert-almost-equal-remove branch from 8b8af9b to 0dd458e Compare May 1, 2017 20:15
@jreback jreback added the Testing pandas testing functions or related to the test suite label May 2, 2017
@jreback jreback added this to the 0.20.0 milestone May 2, 2017
@jreback jreback merged commit 85c4879 into pandas-dev:master May 2, 2017
@gfyoung gfyoung deleted the assert-almost-equal-remove branch May 2, 2017 00:51
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants