Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Categorical scatter plot has KeyError #16199 #16208

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

stangirala
Copy link
Contributor

@stangirala stangirala commented May 3, 2017

Appropriately handles categorical data for dataframe scatter plots which
currently raises KeyError for categorical data

@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #16208 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16208      +/-   ##
==========================================
- Coverage   90.93%   90.93%   -0.01%     
==========================================
  Files         161      161              
  Lines       49269    49273       +4     
==========================================
+ Hits        44802    44804       +2     
- Misses       4467     4469       +2
Flag Coverage Δ
#multiple 88.68% <50%> (-0.01%) ⬇️
#single 40.22% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 81.83% <50%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a428d...035e00d. Read the comment docs.

@jreback jreback added Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas Visualization plotting labels May 3, 2017
@jreback jreback added this to the 0.20.1 milestone May 3, 2017
@jreback
Copy link
Contributor

jreback commented May 3, 2017

I added the whatsnew for 0.20.1, pls rebase and add a note in bug fixes.

@jreback
Copy link
Contributor

jreback commented Jun 10, 2017

can you rebase and update?

move release note to 0.20.3

Appropriately handles categorical data for dataframe scatter plots which
currently raises KeyError for categorical data
@stangirala
Copy link
Contributor Author

@jreback done

@jreback jreback added this to the 0.20.3 milestone Jun 12, 2017
@jreback
Copy link
Contributor

jreback commented Jun 12, 2017

lgtm. @jorisvandenbossche @TomAugspurger

@TomAugspurger TomAugspurger merged commit 11d274f into pandas-dev:master Jun 12, 2017
@TomAugspurger
Copy link
Contributor

Thanks!

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Jul 6, 2017
…ev#16208)

* BUG: Categorical scatter plot has KeyError pandas-dev#16199

Appropriately handles categorical data for dataframe scatter plots which
currently raises KeyError for categorical data

* Add to whatsnew

(cherry picked from commit 11d274f)
TomAugspurger pushed a commit that referenced this pull request Jul 7, 2017
* BUG: Categorical scatter plot has KeyError #16199

Appropriately handles categorical data for dataframe scatter plots which
currently raises KeyError for categorical data

* Add to whatsnew

(cherry picked from commit 11d274f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: scatter plot with categorical data raises KeyError
3 participants