Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option Page Typos #16421

Merged
merged 3 commits into from
May 22, 2017
Merged

Conversation

andymaheshw
Copy link
Contributor

Problem description

There are typos on this page and one confusing sentence. Trying to learn the workflow.

@andymaheshw andymaheshw changed the title Option capitalization Option Page Typos May 22, 2017
@TomAugspurger TomAugspurger added this to the 0.21.0 milestone May 22, 2017
@TomAugspurger TomAugspurger merged commit 1f2085e into pandas-dev:master May 22, 2017
@TomAugspurger
Copy link
Contributor

@andymaheshw thanks! keep em coming!

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, for the rest looks good

@@ -28,7 +28,7 @@ You can get/set options directly as attributes of the top-level ``options`` attr
pd.options.display.max_rows = 999
pd.options.display.max_rows

There is also an API composed of 5 relevant functions, available directly from the ``pandas``
The API is composed of 5 relevant functions, available directly from the ``pandas``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "there is also" does give a bit more the notion of "next to the possibility of directly getting/setting options onpd.options. .., you also have some functions to work with them". So maybe "Additionally, the ..", or "the api is further composed ..." ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ignore this :-) as Tom already merged (not that important)

@codecov
Copy link

codecov bot commented May 22, 2017

Codecov Report

Merging #16421 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16421      +/-   ##
==========================================
+ Coverage   90.42%   90.42%   +<.01%     
==========================================
  Files         161      161              
  Lines       51023    51023              
==========================================
+ Hits        46137    46138       +1     
+ Misses       4886     4885       -1
Flag Coverage Δ
#multiple 88.26% <ø> (ø) ⬆️
#single 40.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/common.py 91.39% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a681b...0c59a99. Read the comment docs.

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
* capitalization update

* update

* undoing capitalization
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
* capitalization update

* update

* undoing capitalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants