Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the memory usage explanation of categorical in gotchas from O(n… #17736

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fixed the memory usage explanation of categorical in gotchas from O(n… #17736

merged 1 commit into from
Oct 2, 2017

Conversation

berkay-dincer
Copy link
Contributor

@berkay-dincer berkay-dincer commented Oct 2, 2017

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #17736 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17736      +/-   ##
==========================================
+ Coverage   91.23%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       49796    49796              
==========================================
+ Hits        45430    45433       +3     
+ Misses       4366     4363       -3
Flag Coverage Δ
#multiple 89.03% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408ecd2...439cefc. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #17736 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17736      +/-   ##
==========================================
+ Coverage   91.23%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       49796    49796              
==========================================
+ Hits        45430    45433       +3     
+ Misses       4366     4363       -3
Flag Coverage Δ
#multiple 89.03% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408ecd2...439cefc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #17736 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17736      +/-   ##
==========================================
+ Coverage   91.23%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       49796    49796              
==========================================
+ Hits        45430    45433       +3     
+ Misses       4366     4363       -3
Flag Coverage Δ
#multiple 89.03% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408ecd2...439cefc. Read the comment docs.

@jreback jreback added Categorical Categorical Data Type Docs labels Oct 2, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 2, 2017
@jreback jreback merged commit 361ef9e into pandas-dev:master Oct 2, 2017
@jreback
Copy link
Contributor

jreback commented Oct 2, 2017

thanks!

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 2, 2017
* 'master' of github.com:pandas-dev/pandas: (188 commits)
  Separate out _convert_datetime_to_tsobject (pandas-dev#17715)
  DOC: remove whatsnew note for xref pandas-dev#17131
  BUG: Regression in .loc accepting a boolean Index as an indexer (pandas-dev#17738)
  DEPR: Deprecate cdate_range and merge into bdate_range (pandas-dev#17691)
  CLN: replace %s syntax with .format in pandas.core: categorical, common, config, config_init (pandas-dev#17735)
  Fixed the memory usage explanation of categorical in gotchas from O(nm) to O(n+m) (pandas-dev#17736)
  TST: add backward compat for offset testing for pickles (pandas-dev#17733)
  remove unused time conversion funcs (pandas-dev#17711)
  DEPR: Deprecate convert parameter in take (pandas-dev#17352)
  BUG:Time Grouper bug fix when applied for list groupers (pandas-dev#17587)
  BUG: Fix some PeriodIndex resampling issues (pandas-dev#16153)
  BUG: Fix unexpected sort in groupby (pandas-dev#17621)
  DOC: Fixed typo in documentation for 'pandas.DataFrame.replace' (pandas-dev#17731)
  BUG: Fix series rename called with str altering name rather index (GH17407) (pandas-dev#17654)
  DOC: Add examples for MultiIndex.get_locs + cleanups (pandas-dev#17675)
  Doc improvements for IntervalIndex and Interval (pandas-dev#17714)
  BUG: DataFrame sort_values and multiple "by" columns fails to order NaT correctly
  Last of the timezones funcs (pandas-dev#17669)
  Add missing file to _pyxfiles, delete commented-out (pandas-dev#17712)
  update imports of DateParseError, remove unused imports from tslib (pandas-dev#17713)
  ...
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Categorical gotchas says memory usage is O(nm), when it is actually O(n+m)
2 participants