DOC/BLD: update vendored IPython.sphinxext version

[jorisvandenbossche]

updated to commit cc353b25b0fff58e4ed13899df9b3c8153df01d9 from ipython/ipython

xref #18147, #19687

Alternative for #19657 until new release of IPython is out

[pep8speaks]

Hello @jorisvandenbossche! Thanks for submitting the PR.

• In the file doc/sphinxext/ipython_sphinxext/ipython_console_highlighting.py, following are the PEP8 issues :

Line 23:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file doc/sphinxext/ipython_sphinxext/ipython_directive.py, following are the PEP8 issues :

Line 230:80: E501 line too long (95 > 79 characters)
Line 232:80: E501 line too long (80 > 79 characters)
Line 353:80: E501 line too long (84 > 79 characters)
Line 354:65: E231 missing whitespace after ','
Line 391:39: E261 at least two spaces before inline comment
Line 525:5: E303 too many blank lines (2)
Line 538:27: E261 at least two spaces before inline comment
Line 585:32: E225 missing whitespace around operator
Line 615:44: E228 missing whitespace around modulo operator
Line 883:12: E713 test for membership should be 'not in'

[jorisvandenbossche]

The doc build on travis looks good, and locally as well.

I think the biggest difference in removing/overwriting our own version is that we no longer have the custom DecodingStringIO that was introduced in #6185 to deal with unicode execution results when building the docs (I think this was specifically on Windows, in any case on linux it is working, but would be nice if somebody could test this on Windows)

[jorisvandenbossche]

BTW, I am not going to fix those PEP8 linting warnings, since this would deviate us again from upstream. The linter on travis does not fail on it in any case.

[codecov]

Codecov Report

Merging #19765 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19765   +/-   ##
=======================================
  Coverage    91.6%    91.6%           
=======================================
  Files         150      150           
  Lines       48864    48864           
=======================================
  Hits        44763    44763           
  Misses       4101     4101

Flag	Coverage Δ
#multiple	89.98% <ø> (ø)	⬆️
#single	41.75% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df5ab7...b9079e9. Read the comment docs.

[jorisvandenbossche]

Merging this, but it would still be good to get feedback from somebody using Windows