BUG: Handle all-NA blocks in concat #20382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we special cased all-na blocks. We should only do that for non-extension dtypes.
TomAugspurger
added
Missing-data
jschendel
reviewed
Mar 16, 2018
| @@ -25,6 +25,21 @@ def test_concat(self, data, in_frame): | |||
| assert dtype == data.dtype | |||
| assert isinstance(result._data.blocks[0], ExtensionBlock) | |||
|
|
|||
| @pytest.mark.parametrize('in_frame', [True]) | |||
There was a problem hiding this comment.
Should this be [True, False]? If False isn't supported yet, might be nice to write a quick comment, as separate code paths for False exist in the test.
There was a problem hiding this comment.
Yeah, was debugging that case. Thanks.
Codecov Report
@@ Coverage Diff @@
## master #20382 +/- ##
=========================================
Coverage ? 91.79%
=========================================
Files ? 152
Lines ? 49184
Branches ? 0
=========================================
Hits ? 45148
Misses ? 4036
Partials ? 0
Continue to review full report at Codecov.
|
|
lgtm. |
|
The linting error was fixed on master: |
nehiljain
added a commit
to nehiljain/pandas
that referenced
this pull request
Mar 21, 2018
…ame_describe * upstream/master: (158 commits) Add link to "Craft Minimal Bug Report" blogpost (pandas-dev#20431) BUG: fixed json_normalize for subrecords with NoneTypes (pandas-dev#20030) (pandas-dev#20399) BUG: ExtensionArray.fillna for scalar values (pandas-dev#20412) DOC" update the Pandas core window rolling count docstring" (pandas-dev#20264) DOC: update the pandas.DataFrame.plot.hist docstring (pandas-dev#20155) DOC: Only use ~ in class links to hide prefixes. (pandas-dev#20402) Bug: Allow np.timedelta64 objects to index TimedeltaIndex (pandas-dev#20408) DOC: add disallowing of Series construction of len-1 list with index to whatsnew (pandas-dev#20392) MAINT: Remove weird pd file DOC: update the Index.isin docstring (pandas-dev#20249) BUG: Handle all-NA blocks in concat (pandas-dev#20382) DOC: update the pandas.core.resample.Resampler.fillna docstring (pandas-dev#20379) BUG: Don't raise exceptions splitting a blank string (pandas-dev#20067) DOC: update the pandas.DataFrame.cummax docstring (pandas-dev#20336) DOC: update the pandas.core.window.x.mean docstring (pandas-dev#20265) DOC: update the api.types.is_number docstring (pandas-dev#20196) Fix linter (pandas-dev#20389) DOC: Improved the docstring of pandas.Series.dt.to_pytimedelta (pandas-dev#20142) DOC: update the pandas.Series.dt.is_month_end docstring (pandas-dev#20181) DOC: update the window.Rolling.min docstring (pandas-dev#20263) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we special cased all-na blocks. We should only do that for
non-extension dtypes.