Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional DOC and BUG fix related to merging with mix of columns and… #20475

Merged
merged 9 commits into from
Dec 4, 2018

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Mar 23, 2018

Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):

This PR adds some documentation about how MultiLevel index levels are dropped when doing a merge that includes levels and columns. It also fixes a small bug related to join.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #20475 into master will increase coverage by 49.74%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #20475       +/-   ##
===========================================
+ Coverage   42.51%   92.25%   +49.74%     
===========================================
  Files         161      161               
  Lines       51691    51692        +1     
===========================================
+ Hits        21975    47690    +25715     
+ Misses      29716     4002    -25714
Flag Coverage Δ
#multiple 90.66% <100%> (?)
#single 42.51% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.28% <100%> (+84.55%) ⬆️
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 58.36% <0%> (+8.17%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/api.py 100% <0%> (+14.81%) ⬆️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940104e...d0b6aed. Read the comment docs.



def test_join_multi_to_multi():
leftindex = MultiIndex.from_product([list('abc'), list('xy'), [1, 2]],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this issue number here

ideally can you use the join_type fixture here (to run this for all join types)

@jreback
Copy link
Contributor

jreback commented Mar 31, 2018

you showed 3 examples in the OP, can you replicate them here

@jreback jreback added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 2, 2018
@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Apr 3, 2018

@jreback I made the changes you asked for and it's all green

@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

@Dr-Irv this got a bit lost, can you rebase and update

@pep8speaks
Copy link

Hello @Dr-Irv! Thanks for updating the PR.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Nov 1, 2018

@jreback merged with latest, and now all green. I now added a line in whatsnew.

@datapythonista
Copy link
Member

@Dr-Irv sorry this wasn't merged before, can you do one more rebase please?

@datapythonista
Copy link
Member

@jreback

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Nov 26, 2018

@datapythonista now all green

@datapythonista
Copy link
Member

Sorry @Dr-Irv, another rebase needed.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Dec 3, 2018

@datapythonista I've done the merge, but the failure is because there is something wrong on Azure. Up to you to decide how to proceed.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Dec 4, 2018

@datapythonista Current merge is now all green.

@jreback jreback added this to the 0.24.0 milestone Dec 4, 2018
@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

lgtm. @Dr-Irv just pushed a commit to fix whitespace. ping on green.

@jreback jreback added the Bug label Dec 4, 2018
@jreback jreback merged commit d7e96d8 into pandas-dev:master Dec 4, 2018
@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

thanks @Dr-Irv

@Dr-Irv Dr-Irv deleted the issue20452 branch July 12, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: New feature allowing merging on combination of columns and index levels drops levels of index
4 participants