PKG: remove pyproject.toml for now #20718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this what is causing the wheel build issues? |
|
That's still something else I think. It's also related to the release of pip 10, but because they changed some api's that multibuild relied upon: https://github.com/matthew-brett/multibuild/issues/159 |
|
Going to merge this, as currently it is just broken. We can always add back before the 0.23.0 release if pip is updated by then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this gives problems, it might be better to remove this until support in pip is better?
Eg I also have errors on the geopandas CI when installing pandas master with pip due to this.
Scipy did something similar: scipy/scipy#8735