Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : read_json with table='orient' causes unexpected type coercion #21408

Closed
wants to merge 2 commits into from

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 10, 2018

BUG : read_json with table='orient' causes unexpected type coercion #21345

Changed .astype parameters according to the comments. Should work now

BUG : read_json with table='orient' causes unexpected type coercion pandas-dev#21345
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 10, 2018

@WillAyd @pyryjook @jreback please have a look and kindly mention any drawback on which I may need to work on in this patch

@gfyoung gfyoung added the IO JSON read_json, to_json, json_normalize label Jun 10, 2018
@gfyoung
Copy link
Member

gfyoung commented Jun 10, 2018

@uds5501 :

  • Looks like you have test failures...
  • Also add a whatsnew + new test

@WillAyd
Copy link
Member

WillAyd commented Jun 10, 2018

I mentioned this in one of the other threads but I don't think we should even be calling _try_convert_data at all since the schema explicitly tells us what the types are.

Can you check the call stack from this and see if there's a way to not even call this method at all?

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 13, 2018

@WillAyd Good point there. I will try and make a work around here

@uds5501 uds5501 closed this Jun 19, 2018
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 19, 2018

Closing this for now, will try and create a workaround locally first. Till then, if anyone else is interested in picking up this issue, be my guest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_json with table='orient' causes unexpected type coercion
3 participants