BUG: Fix Index construction when given empty generator (#21470). #21481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21481 +/- ##
=========================================
Coverage ? 91.92%
=========================================
Files ? 153
Lines ? 49586
Branches ? 0
=========================================
Hits ? 45582
Misses ? 4004
Partials ? 0
Continue to review full report at Codecov.
|
mroeschke
reviewed
Jun 14, 2018
pandas/tests/indexes/test_base.py
Outdated
| @@ -445,14 +445,22 @@ def test_constructor_dtypes_timedelta(self, attr, klass): | |||
| result = klass(list(values), dtype=dtype) | |||
| tm.assert_index_equal(result, index) | |||
|
|
|||
| def test_constructor_empty_gen(self): | |||
| def test_constructor_empty_list(self): | |||
There was a problem hiding this comment.
Could you combine this test with the one below with pytest.mark.parametrize over skip_index_keys and the empty list and generator?
mroeschke
added
Bug
Regression
|
Maybe also worthwhile to include a test for |
|
@mroeschke Thanks--good call on including iter([]) in tests- turns out calling CategoricalIndex on any non-generator iterator was broken. |
jreback
requested changes
Jun 15, 2018
jreback
approved these changes
Jun 18, 2018
|
thanks @Liam3851 |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jun 29, 2018
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jul 2, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff