TST: Parametrize tests in tests/util/test_hashing.py #21883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Testing
jschendel
force-pushed
the
parametrize-test-hashing
branch
from
e1e5daa
to
3124d0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #21883 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 164 164
Lines 49992 49992
=======================================
Hits 45952 45952
Misses 4040 4040
Continue to review full report at Codecov.
|
gfyoung
approved these changes
Jul 13, 2018
|
thanks @jschendel |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that these tests could be parametrized when investigating a comment in the
IntervalArrayPR, and originally started doing to work there. TheIntervalArrayPR is big enough already, and this is unrelated, so creating a separate PR.