BUG:Clip with a list-like threshold with a nan is broken (GH19992) #21921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
makbigc
commented
Jul 15, 2018
•
makbigc
commented
- fix bug BUG: clip with a list-like threshold with a nan is broken #19992
- 2 tests amended in frame/test_analytics.py and series/test_analytics.py
- whatsnew entry added
Codecov Report
@@ Coverage Diff @@
## master #21921 +/- ##
=======================================
Coverage 91.96% 91.96%
=======================================
Files 166 166
Lines 50329 50329
=======================================
Hits 46287 46287
Misses 4042 4042
Continue to review full report at Codecov.
|
jreback
requested changes
Jul 16, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -440,6 +440,7 @@ Missing | |||
|
|
|||
| - Bug in :func:`DataFrame.fillna` where a ``ValueError`` would raise when one column contained a ``datetime64[ns, tz]`` dtype (:issue:`15522`) | |||
| - Bug in :func:`Series.hasnans` that could be incorrectly cached and return incorrect answers if null elements are introduced after an initial call (:issue:`19700`) | |||
| - Bug in :func:`Series.clip` and `DataFrame.clip` cannot accept list-like threshold containing nan (:issue:`19992`) | |||
There was a problem hiding this comment.
can you add the ref for DataFrame, use double back-ticks on NaN (and sp)
| tm.assert_frame_equal(self.frame.clip(upper=np.nan, lower=np.nan), | ||
| self.frame) | ||
|
|
||
| # GH #19992 |
There was a problem hiding this comment.
can you comment under the commit number what this is testing
use
result =
expected =
tm.assert_frame_equal(....)
do the tests in order for axis=0, axis=0, IOW so you don't have the df1, df2 variables
There was a problem hiding this comment.
Amended. Your format is better. Thanks.
|
does this also close #19976 ? |
jreback
added
Bug
Missing-data
jreback
requested changes
Jul 17, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -440,6 +440,7 @@ Missing | |||
|
|
|||
| - Bug in :func:`DataFrame.fillna` where a ``ValueError`` would raise when one column contained a ``datetime64[ns, tz]`` dtype (:issue:`15522`) | |||
| - Bug in :func:`Series.hasnans` that could be incorrectly cached and return incorrect answers if null elements are introduced after an initial call (:issue:`19700`) | |||
| - Bug in :func:`Series.clip` and :func:`DataFrame.clip` cannot accept list-like threshold containing ``NaN`` (:issue:`19992`) | |||
There was a problem hiding this comment.
go ahead and move to 0.23.4
jreback
approved these changes
Jul 18, 2018
|
thanks @makbigc |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Jul 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.