DOC/DEPR: clarify argmin/argmax deprecation message #22310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/series.py
Outdated
| 'argmin' is deprecated, use 'idxmin' instead. The behavior of 'argmin' | ||
| will be corrected to return the positional minimum in the future. | ||
| Use 'series.values.argmin' to get the position of the minimum row.""") | ||
| the behaviour of 'Series.argmin' is deprecated, use 'idxmin' instead. |
There was a problem hiding this comment.
Capitalize "the". And maybe add the current behavior.
LGTM otherwise.
Codecov Report
@@ Coverage Diff @@
## master #22310 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 169 169
Lines 50691 50691
=======================================
Hits 46681 46681
Misses 4010 4010
Continue to review full report at Codecov.
|
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
* DOC/DEPR: clarify argmin/argmax deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to better phrase the message, xref #16830 (comment)