Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fixturize series/test_validate.py #22756

Merged
merged 5 commits into from
Sep 25, 2018

Conversation

Anjali2019
Copy link
Contributor

This is in reference to issue #22550

@pep8speaks
Copy link

Hello @Anjali2019! Thanks for submitting the PR.

@Anjali2019 Anjali2019 changed the title Tst series validate TST: Fixturize series/test_validate.py Sep 18, 2018
@h-vetinari
Copy link
Contributor

Same comment as in #22771:
You have an open PR for test_analytics.py already, so you should remove that (git revert <hash>) from this PR.

More generally, make sure that you're on master (git checkout master) before you open a new branch.

On the plus side, all the CI failures are unrelated to your PR. Once you push a new commit, things should (hopefully) run through fine.

@Anjali2019
Copy link
Contributor Author

Same comment as in #22771:
You have an open PR for test_analytics.py already, so you should remove that (git revert <hash>) from this PR.

More generally, make sure that you're on master (git checkout master) before you open a new branch.
Yes will make sure of that and will revert unrelated commits (y)

This reverts commit 3678a62.
@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #22756 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22756      +/-   ##
==========================================
+ Coverage   92.16%   92.18%   +0.02%     
==========================================
  Files         169      169              
  Lines       50769    50810      +41     
==========================================
+ Hits        46791    46839      +48     
+ Misses       3978     3971       -7
Flag Coverage Δ
#multiple 90.6% <ø> (+0.02%) ⬆️
#single 42.37% <ø> (+0.05%) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/base.py 100% <0%> (ø) ⬆️
pandas/core/generic.py 96.67% <0%> (ø) ⬆️
pandas/util/testing.py 86.03% <0%> (ø) ⬆️
pandas/core/frame.py 97.2% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 95.45% <0%> (ø) ⬆️
pandas/io/formats/excel.py 97.4% <0%> (ø) ⬆️
pandas/core/arrays/categorical.py 95.75% <0%> (+0.01%) ⬆️
pandas/core/base.py 97.61% <0%> (+0.01%) ⬆️
pandas/core/arrays/datetimelike.py 95.53% <0%> (+0.02%) ⬆️
pandas/core/dtypes/dtypes.py 96.11% <0%> (+0.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a12c41...2711fda. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Sep 23, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @jreback

@jreback jreback added this to the 0.24.0 milestone Sep 25, 2018
@jreback jreback merged commit 183a416 into pandas-dev:master Sep 25, 2018
@jreback
Copy link
Contributor

jreback commented Sep 25, 2018

thanks @Anjali2019

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@Anjali2019 Anjali2019 deleted the tst_series_validate branch October 3, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants