Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: SparseArray.unique with all sparse #23186

Merged
merged 2 commits into from
Oct 18, 2018
Merged

BUG: SparseArray.unique with all sparse #23186

merged 2 commits into from
Oct 18, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Oct 16, 2018 •
edited
Loading

xref #23168

Closes #19595

@TomAugspurger TomAugspurger added the Sparse Sparse Data Type label Oct 16, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 16, 2018
@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #23186 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23186      +/-   ##
==========================================
- Coverage   92.19%   92.19%   -0.01%     
==========================================
  Files         169      169              
  Lines       50959    50956       -3     
==========================================
- Hits        46980    46977       -3     
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.61% <100%> (-0.01%) ⬇️
#single 42.27% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/sparse.py 92.55% <100%> (ø) ⬆️
pandas/core/indexes/numeric.py 97.27% <0%> (-0.15%) ⬇️
pandas/core/indexes/base.py 96.55% <0%> (ø) ⬆️
pandas/core/reshape/merge.py 93.94% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913f71f...abedfe5. Read the comment docs.

jreback
jreback requested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add this issue to the sparse array refactor issue. also I think there is an open sparse unique issue as well? #19595

pandas/core/arrays/sparse.py Outdated
@@ -809,7 +809,7 @@ def _first_fill_value_loc(self):
return -1

indices = self.sp_index.to_int_index().indices
if indices[0] > 0:
if len(indices) == 0 or indices[0] > 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not len(indices) ?

@TomAugspurger TomAugspurger mentioned this pull request Oct 17, 2018
Closed
4 tasks
@TomAugspurger
Copy link
Contributor Author

Ignoring the windows CI failure from yesterday.

@TomAugspurger TomAugspurger merged commit dc5ef66 into pandas-dev:master Oct 18, 2018
@TomAugspurger TomAugspurger deleted the sparse-unique-fix branch October 18, 2018 11:26
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@TomAugspurger @tm9k1
BUG: SparseArray.unique with all sparse (pandas-dev#23186)
6b01665 
* BUG: SparseArray.unique with all sparse

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Sparse Sparse Data Type
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @pep8speaks @jreback