Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: DatetimeLikeArray #24024

Merged
merged 220 commits into from
Jan 2, 2019
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
220 commits
Select commit Hold shift + click to select a range
e9c8418
Squashed commit of the following:
TomAugspurger Nov 30, 2018
80d9576
Squashed commit of the following:
TomAugspurger Nov 30, 2018
acd5b6d
Squashed commit of the following:
TomAugspurger Nov 30, 2018
f364f77
REF: DatetimeArray
TomAugspurger Nov 30, 2018
56d9af6
fixup! REF: DatetimeArray
TomAugspurger Nov 30, 2018
538db1f
fixup! REF: DatetimeArray
TomAugspurger Nov 30, 2018
6620b0f
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 3, 2018
4842e53
fixup
TomAugspurger Dec 3, 2018
a7c1d42
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 3, 2018
07586d9
fixup
TomAugspurger Dec 3, 2018
7ebb9ee
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 4, 2018
e843984
REF: Move dispatched properties to array, not like
TomAugspurger Dec 4, 2018
67a9cf9
TST: Work around statsmodels bug (#24090)
TomAugspurger Dec 4, 2018
09837ac
fixups
TomAugspurger Dec 4, 2018
f3f9142
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 4, 2018
7c76b3e
fixups
TomAugspurger Dec 5, 2018
eae133d
fixups
TomAugspurger Dec 5, 2018
165f3fd
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 5, 2018
7ec7351
Squashed commit of the following:
TomAugspurger Dec 5, 2018
e7538e6
Fixed: where
TomAugspurger Dec 5, 2018
4f1ee37
revert constructor change
TomAugspurger Dec 5, 2018
a117de4
some cleanups
TomAugspurger Dec 5, 2018
1f463a1
Squashed commit of the following:
TomAugspurger Dec 6, 2018
d5fdc21
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 6, 2018
98182b1
Fixed IO pytables
TomAugspurger Dec 6, 2018
d4c9521
wip:constructor
TomAugspurger Dec 6, 2018
c22a30a
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 7, 2018
abd019a
Squashed commit of the following:
TomAugspurger Dec 7, 2018
4e9608e
Boxing compat
TomAugspurger Dec 7, 2018
4988630
test fixups
TomAugspurger Dec 7, 2018
3eb8432
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 7, 2018
2a562b8
Revert "Squashed commit of the following:"
TomAugspurger Dec 7, 2018
f4cbf36
hacky where fix
TomAugspurger Dec 7, 2018
b366968
basic unstack test
TomAugspurger Dec 7, 2018
fef6847
where fixups
TomAugspurger Dec 7, 2018
9c19b8c
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 7, 2018
3970f62
Cleanup
TomAugspurger Dec 7, 2018
9a50f92
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 8, 2018
ebb4009
unxfail
TomAugspurger Dec 8, 2018
57b401e
lint
TomAugspurger Dec 8, 2018
0a61ba8
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 9, 2018
323bfeb
clarify _values behavior
TomAugspurger Dec 9, 2018
2c1719f
remove xfail
TomAugspurger Dec 9, 2018
62bf6c6
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 10, 2018
0a8ccfd
[WIP]: Fixed groupby resample
TomAugspurger Dec 10, 2018
d5f2ac2
wip
TomAugspurger Dec 10, 2018
831d91a
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 10, 2018
e69ba08
EA-Where cleanup
TomAugspurger Dec 10, 2018
c31b80e
wip: remove wrap_array_method
TomAugspurger Dec 10, 2018
b4a0dc6
wip: more dispatching
TomAugspurger Dec 10, 2018
8c0641b
wip: py2 compat
TomAugspurger Dec 10, 2018
5d7dfda
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 10, 2018
580f7ba
old DTI pickle compat
TomAugspurger Dec 10, 2018
c41ec57
REF: TDA Constructor
TomAugspurger Dec 10, 2018
558adf8
WIP: Fix json serialization
TomAugspurger Dec 6, 2018
6586bcd
fixup! WIP: Fix json serialization
TomAugspurger Dec 11, 2018
5777ed0
TDA Constructor fixups
TomAugspurger Dec 11, 2018
d20291f
Constructors
TomAugspurger Dec 11, 2018
0f231e7
versionadded
TomAugspurger Dec 11, 2018
5f473df
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 11, 2018
c3b7dea
Ops updates
TomAugspurger Dec 11, 2018
074eed9
Cleanup
TomAugspurger Dec 11, 2018
02145d9
edge cases
TomAugspurger Dec 11, 2018
bf57186
fixups
TomAugspurger Dec 11, 2018
af34a0d
32-bit compat
TomAugspurger Dec 11, 2018
d557976
32-bit compat
TomAugspurger Dec 12, 2018
87f18e3
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 12, 2018
afc4c4a
Astype fixups
TomAugspurger Dec 12, 2018
3702801
doc comment
TomAugspurger Dec 12, 2018
119575f
32-bit compat
TomAugspurger Dec 12, 2018
0cd6958
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 12, 2018
4371ed0
TST: tighten up matches
TomAugspurger Dec 12, 2018
629e8e5
Add API breaking release notes
TomAugspurger Dec 12, 2018
a9a2101
Unique docstring
TomAugspurger Dec 12, 2018
4c460c6
py27, 64bit compat
TomAugspurger Dec 12, 2018
ac734b3
maybe fix 0.24 syntax
TomAugspurger Dec 12, 2018
b485e5a
Large cleanup
TomAugspurger Dec 12, 2018
f7d9cdb
BUG: Fixed DataFrame.values for 1 column DataFrame
TomAugspurger Dec 12, 2018
a86e4cb
Cleanup
TomAugspurger Dec 13, 2018
462a4f7
Hide one
TomAugspurger Dec 13, 2018
b901c3d
JSON comments
TomAugspurger Dec 13, 2018
4bf1862
Fixups
TomAugspurger Dec 13, 2018
7dd3ba5
Some cleanups
TomAugspurger Dec 13, 2018
87101bf
Fixup DatetimeTZBlock.get_values
TomAugspurger Dec 13, 2018
8c6f2db
Fixed datetimelike-max
TomAugspurger Dec 13, 2018
6bfd919
Document IncompatibleTimezoneError
TomAugspurger Dec 13, 2018
4cb6c50
Update concat test
TomAugspurger Dec 13, 2018
4c1609a
dispatch _to_json_values
TomAugspurger Dec 13, 2018
e7505cd
clarifying comments
TomAugspurger Dec 13, 2018
8060edd
Added check for ABCDatetimeArray & ABCPeriodArray
TomAugspurger Dec 13, 2018
55f6c26
Docstring for DatetimeTZDtype
TomAugspurger Dec 13, 2018
ef11a07
Use super for _add_delta
TomAugspurger Dec 13, 2018
17a3bbb
Remove redundant properties
TomAugspurger Dec 13, 2018
48f85f0
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 13, 2018
4ec0284
Dispatch tz, tzinfo
TomAugspurger Dec 13, 2018
aa82a0b
Updates
TomAugspurger Dec 13, 2018
d7dcd79
Added some docs
TomAugspurger Dec 13, 2018
34c2bd1
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 14, 2018
d0a266e
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 14, 2018
94fd88b
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 14, 2018
75df1c9
Print wrong dtype
TomAugspurger Dec 14, 2018
82c998a
Fix new failures
TomAugspurger Dec 14, 2018
9252c75
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 14, 2018
512af69
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 15, 2018
80b3455
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 16, 2018
87c125b
Update for comments
TomAugspurger Dec 16, 2018
b9f2d4e
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 17, 2018
a695eb8
minor cleanups
TomAugspurger Dec 17, 2018
bbc5f1b
Remove ref_to_data, deepcopy_if_needed
TomAugspurger Dec 17, 2018
a22f22c
Remove CategoricalIndex._index_data
TomAugspurger Dec 18, 2018
0aff5fa
Private _hasnans
TomAugspurger Dec 18, 2018
90a937f
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 18, 2018
1566c1e
really remove _deepcopy_if_needed
TomAugspurger Dec 18, 2018
cc80a8e
removed nbs
TomAugspurger Dec 18, 2018
58f3421
CLN: Removed unused wrap_array_method and accessor
TomAugspurger Dec 18, 2018
99bc78e
Remove unused setop handling
TomAugspurger Dec 18, 2018
ee48dc0
Notes on _index_data
TomAugspurger Dec 18, 2018
6e487c6
clarify comment
TomAugspurger Dec 18, 2018
f4aa1f8
Cleanups
TomAugspurger Dec 18, 2018
d81c204
Updates
TomAugspurger Dec 19, 2018
d821927
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 19, 2018
617a172
remove IncompatibleTimezoneError
TomAugspurger Dec 19, 2018
32ef700
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 19, 2018
0a0df77
add nonexistent
TomAugspurger Dec 19, 2018
169eae6
Fixed to_numpy on datetimetz
TomAugspurger Dec 19, 2018
be4335d
Try removing index _generate_ranges
TomAugspurger Dec 19, 2018
203a5a6
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 19, 2018
fab4c33
use _data
TomAugspurger Dec 19, 2018
89b5b51
Check before unboxing
TomAugspurger Dec 19, 2018
b2afd4e
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 20, 2018
a874f5f
na in unbox
TomAugspurger Dec 20, 2018
0eb28e8
Try removing freq infer
TomAugspurger Dec 20, 2018
42dfd30
bits of 24364
jbrockmendel Dec 20, 2018
f62544a
Merge pull request #6 from jbrockmendel/disown2
TomAugspurger Dec 21, 2018
2e30a56
Updates
TomAugspurger Dec 21, 2018
af815f8
Small updates
TomAugspurger Dec 21, 2018
b046791
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 21, 2018
4522dfe
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 21, 2018
eb594e7
Merge branch 'master' of https://github.com/pandas-dev/pandas into di…
jbrockmendel Dec 24, 2018
0b570b1
Merge pull request #7 from jbrockmendel/disown3
TomAugspurger Dec 27, 2018
72fe4fc
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 27, 2018
7a711f9
remove DatetimeTZBlock.shift
TomAugspurger Dec 27, 2018
6530500
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 27, 2018
445e46a
Merge branch 'master' of https://github.com/pandas-dev/pandas into di…
jbrockmendel Dec 28, 2018
9ae6706
Merge pull request #8 from jbrockmendel/disown5
TomAugspurger Dec 28, 2018
60ddcb5
Merge branch 'disown-tz-only-rebased' of https://github.com/TomAugspu…
TomAugspurger Dec 28, 2018
5988477
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 28, 2018
20c23b7
matching errors
TomAugspurger Dec 28, 2018
7a5fd94
isort
TomAugspurger Dec 28, 2018
e644d8c
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 28, 2018
4d3b55e
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 28, 2018
68cde94
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 28, 2018
421435a
Merge branch 'master' of https://github.com/pandas-dev/pandas into di…
jbrockmendel Dec 29, 2018
bbf7fa4
Merge pull request #9 from jbrockmendel/disown7
TomAugspurger Dec 29, 2018
324d452
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 29, 2018
cdec2a8
Removed pandas_registry and related tests
TomAugspurger Dec 29, 2018
e66c18b
Updates
TomAugspurger Dec 29, 2018
09c2c91
wrong branch
TomAugspurger Dec 29, 2018
6373948
Fix mixup from previous rebase
jbrockmendel Dec 29, 2018
e91bc09
Merge branch 'master' of https://github.com/pandas-dev/pandas into di…
jbrockmendel Dec 29, 2018
4bf00d8
Merge pull request #10 from jbrockmendel/disown8
TomAugspurger Dec 29, 2018
8cb7d9e
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 29, 2018
23fd9bb
fixup
TomAugspurger Dec 29, 2018
695010c
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 29, 2018
ec2c7af
move null-handling methods back down to null-handling section
jbrockmendel Dec 29, 2018
a499ed8
restore order of null-handling section
jbrockmendel Dec 29, 2018
a32e020
Small diff cleanups
jbrockmendel Dec 29, 2018
6d2fc99
Merge pull request #11 from jbrockmendel/na
TomAugspurger Dec 30, 2018
9342b59
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 30, 2018
c566ce8
Shift -> _data.time_shift
TomAugspurger Dec 30, 2018
f783770
Freq changes
TomAugspurger Dec 30, 2018
9502f90
Merge branch 'master' of https://github.com/pandas-dev/pandas into di…
jbrockmendel Dec 31, 2018
3e1ee5e
fix rebase scerwup
jbrockmendel Dec 31, 2018
92d8089
fix shift
jbrockmendel Dec 31, 2018
cbb90f7
fixups
jbrockmendel Dec 31, 2018
be1c968
Merge pull request #12 from jbrockmendel/disown10
TomAugspurger Dec 31, 2018
c655592
Merge branch 'disown-tz-only-rebased' of https://github.com/TomAugspu…
TomAugspurger Dec 31, 2018
8d2108a
eadata fixup
TomAugspurger Dec 31, 2018
fafa1ea
Fixed test overriting freq
TomAugspurger Dec 31, 2018
01f185b
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Dec 31, 2018
efa1c2c
remove unnecessary condition
TomAugspurger Dec 31, 2018
a65efb0
Update .array
TomAugspurger Dec 31, 2018
01115c4
Simplify diff
TomAugspurger Dec 31, 2018
9d37675
Revert eadata -> data changes
TomAugspurger Dec 31, 2018
38817a5
fix failing tests
jbrockmendel Jan 1, 2019
8fad32e
Merge pull request #13 from jbrockmendel/cifix
TomAugspurger Jan 1, 2019
5dbc63a
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 1, 2019
7de78f1
Merge branch 'disown-tz-only-rebased' of https://github.com/TomAugspu…
TomAugspurger Jan 1, 2019
7544bcf
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 1, 2019
39a2a67
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 1, 2019
6e90823
import
TomAugspurger Jan 1, 2019
9e61b5b
Fixed failing test
TomAugspurger Jan 1, 2019
0be63a6
Try reverting dt64arr_to_periodarr
TomAugspurger Jan 1, 2019
90700fb
Minor fixups
TomAugspurger Jan 1, 2019
c77d49c
comment
TomAugspurger Jan 1, 2019
1499344
maybe unnecessary isinstance
TomAugspurger Jan 1, 2019
38a6eb6
Use class
TomAugspurger Jan 1, 2019
b7253d7
32-bit compat
TomAugspurger Jan 1, 2019
f11f07f
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 1, 2019
ca11d27
Fixup merge
TomAugspurger Jan 1, 2019
4c2a620
use to_numpy
TomAugspurger Jan 1, 2019
adddef2
try returning dt64arr
TomAugspurger Jan 1, 2019
9498554
fixup! try returning dt64arr
TomAugspurger Jan 1, 2019
4f1c212
try simplifying categorical case
TomAugspurger Jan 1, 2019
40cdca8
abc
TomAugspurger Jan 1, 2019
756a4b6
Remove DatetimeIndexOpsMixin.__getitem__
TomAugspurger Jan 1, 2019
aea0e05
Remove DatetimeIndexOpsMixin.view
TomAugspurger Jan 1, 2019
dfa7fea
comment
TomAugspurger Jan 1, 2019
cc8b1ca
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 1, 2019
6a2e1a1
Fixup merge
TomAugspurger Jan 1, 2019
b84bef1
Remove unused _time_shift
TomAugspurger Jan 1, 2019
69ed3d4
diff reduction
jbrockmendel Jan 2, 2019
4110b4c
Merge pull request #14 from jbrockmendel/reduction
TomAugspurger Jan 2, 2019
ce5f3b9
just index
TomAugspurger Jan 2, 2019
4c76ae1
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 2, 2019
ef36be1
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 2, 2019
ad4ea4d
fixup merge
TomAugspurger Jan 2, 2019
14a13b0
isort
TomAugspurger Jan 2, 2019
5c8d3c6
remove block
TomAugspurger Jan 2, 2019
2436214
Merge remote-tracking branch 'upstream/master' into disown-tz-only-re…
TomAugspurger Jan 2, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/source/whatsnew/v0.24.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,7 @@ update the ``ExtensionDtype._metadata`` tuple to match the signature of your
- :meth:`DataFrame.stack` no longer converts to object dtype for DataFrames where each column has the same extension dtype. The output Series will have the same dtype as the columns (:issue:`23077`).
- :meth:`Series.unstack` and :meth:`DataFrame.unstack` no longer convert extension arrays to object-dtype ndarrays. Each column in the output ``DataFrame`` will now have the same dtype as the input (:issue:`23077`).
- Bug when grouping :meth:`Dataframe.groupby()` and aggregating on ``ExtensionArray`` it was not returning the actual ``ExtensionArray`` dtype (:issue:`23227`).
- A default repr for :class:`ExtensionArray` is now provided (:issue:`23601`).

.. _whatsnew_0240.api.incompatibilities:

Expand Down Expand Up @@ -1114,6 +1115,7 @@ Deprecations
- The methods :meth:`Series.str.partition` and :meth:`Series.str.rpartition` have deprecated the ``pat`` keyword in favor of ``sep`` (:issue:`22676`)
- Deprecated the `nthreads` keyword of :func:`pandas.read_feather` in favor of
`use_threads` to reflect the changes in pyarrow 0.11.0. (:issue:`23053`)
- :meth:`ExtensionArray._formatting_values` is deprecated. Use `ExtensionArray._formatter` instead. (:issue:`23601`)
- :func:`pandas.read_excel` has deprecated accepting ``usecols`` as an integer. Please pass in a list of ints from 0 to ``usecols`` inclusive instead (:issue:`23527`)
- Constructing a :class:`TimedeltaIndex` from data with ``datetime64``-dtyped data is deprecated, will raise ``TypeError`` in a future version (:issue:`23539`)
- Constructing a :class:`DatetimeIndex` from data with ``timedelta64``-dtyped data is deprecated, will raise ``TypeError`` in a future version (:issue:`23675`)
Expand Down Expand Up @@ -1213,6 +1215,7 @@ Performance Improvements
The speed increase is both when indexing by label (using .loc) and position(.iloc) (:issue:`20395`)
Slicing a monotonically increasing :class:`CategoricalIndex` itself (i.e. ``ci[1000:2000]``)
shows similar speed improvements as above (:issue:`21659`)
- Improved performance of :meth:`CategoricalIndex.equals` when comparing to another :class:`CategoricalIndex` (:issue:`24023`)
- Improved performance of :func:`Series.describe` in case of numeric dtpyes (:issue:`21274`)
- Improved performance of :func:`pandas.core.groupby.GroupBy.rank` when dealing with tied rankings (:issue:`21237`)
- Improved performance of :func:`DataFrame.set_index` with columns consisting of :class:`Period` objects (:issue:`21582`, :issue:`21606`)
Expand Down Expand Up @@ -1278,6 +1281,7 @@ Datetimelike
- Bug in rounding methods of :class:`DatetimeIndex` (:meth:`~DatetimeIndex.round`, :meth:`~DatetimeIndex.ceil`, :meth:`~DatetimeIndex.floor`) and :class:`Timestamp` (:meth:`~Timestamp.round`, :meth:`~Timestamp.ceil`, :meth:`~Timestamp.floor`) could give rise to loss of precision (:issue:`22591`)
- Bug in :func:`to_datetime` with an :class:`Index` argument that would drop the ``name`` from the result (:issue:`21697`)
- Bug in :class:`PeriodIndex` where adding or subtracting a :class:`timedelta` or :class:`Tick` object produced incorrect results (:issue:`22988`)
- Bug in the :class:`Series` repr with period-dtype data missing a space before the data (:issue:`23601`)
- Bug in :func:`date_range` when decrementing a start date to a past end date by a negative frequency (:issue:`23270`)
- Bug in :meth:`Series.min` which would return ``NaN`` instead of ``NaT`` when called on a series of ``NaT`` (:issue:`23282`)
- Bug in :func:`DataFrame.combine` with datetimelike values raising a TypeError (:issue:`23079`)
Expand Down
10 changes: 9 additions & 1 deletion pandas/_libs/reduction.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ cnp.import_array()

cimport util
from lib import maybe_convert_objects
from tslibs.conversion import NS_DTYPE, TD_DTYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these imports used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were unused. Should that be a lint error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC correctly we don't include error code F401 as part of the list for Cython LINTing. Maybe should though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, I periodically do a manual check for unused imports in the cython files.



cdef _get_result_array(object obj, Py_ssize_t size, Py_ssize_t cnt):
Expand Down Expand Up @@ -594,7 +595,14 @@ cdef class BlockSlider:

# move and set the index
self.idx_slider.move(start, end)
object.__setattr__(self.index, '_data', self.idx_slider.buf)

# TODO: unbreak this for other index types, if needed.
# I think the problem is that index.values is an ndarray,
# but index._data is an ExtensionArray.
if self.index.dtype == NS_DTYPE or self.index.dtype == TD_DTYPE:
object.__setattr__(self.index._data, '_data', self.idx_slider.buf)
else:
object.__setattr__(self.index, '_data', self.idx_slider.buf)
self.index._engine.clear_mapping()

cdef reset(self):
Expand Down
62 changes: 57 additions & 5 deletions pandas/core/arrays/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ class ExtensionArray(object):
* copy
* _concat_same_type

An additional method is available to satisfy pandas' internal,
private block API.
A default repr displaying the type, (truncated) data, length,
and dtype is provided. It can be customized or replaced by
by overriding:

* _formatting_values
* __repr__ : A default repr for the ExtensionArray.
* _formatter : Print scalars inside a Series or DataFrame.

Some methods require casting the ExtensionArray to an ndarray of Python
objects with ``self.astype(object)``, which may be expensive. When
Expand Down Expand Up @@ -655,15 +657,65 @@ def copy(self, deep=False):
raise AbstractMethodError(self)

# ------------------------------------------------------------------------
# Block-related methods
# Printing
TomAugspurger marked this conversation as resolved.
Show resolved Hide resolved
# ------------------------------------------------------------------------
def __repr__(self):
from pandas.io.formats.printing import format_object_summary

template = (
u'{class_name}'
u'{data}\n'
u'Length: {length}, dtype: {dtype}'
)
# the short repr has no trailing newline, while the truncated
# repr does. So we include a newline in our template, and strip
# any trailing newlines from format_object_summary
data = format_object_summary(self, self._formatter(), name=False,
trailing_comma=False).rstrip()
class_name = u'<{}>\n'.format(self.__class__.__name__)
return template.format(class_name=class_name, data=data,
length=len(self),
dtype=self.dtype)

def _formatter(self, boxed=False):
# type: (bool) -> Callable[[Any], Optional[str]]
"""Formatting function for scalar values.

This is used in the default '__repr__'. The returned formatting
function receives instances of your scalar type.

Parameters
----------
boxed: bool, default False
An indicated for whether or not your array is being printed
within a Series, DataFrame, or Index (True), or just by
itself (False). This may be useful if you want scalar values
to appear differently within a Series versus on its own (e.g.
quoted or not).

Returns
-------
Callable[[Any], str]
A callable that gets instances of the scalar type and
returns a string. By default, :func:`repr` is used.
"""
return repr

def _formatting_values(self):
# type: () -> np.ndarray
# At the moment, this has to be an array since we use result.dtype
"""An array of values to be printed in, e.g. the Series repr"""
"""An array of values to be printed in, e.g. the Series repr

.. deprecated:: 0.24.0

Use :meth:`ExtensionArray._formatter` instead.
"""
return np.array(self)

# ------------------------------------------------------------------------
# Reshaping
# ------------------------------------------------------------------------

@classmethod
def _concat_same_type(cls, to_concat):
# type: (Sequence[ExtensionArray]) -> ExtensionArray
Expand Down
11 changes: 8 additions & 3 deletions pandas/core/arrays/categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,10 @@ def _constructor(self):
def _from_sequence(cls, scalars, dtype=None, copy=False):
return Categorical(scalars, dtype=dtype)

def _formatter(self, boxed=False):
TomAugspurger marked this conversation as resolved.
Show resolved Hide resolved
# backwards compat with old printing.
return None

def copy(self):
""" Copy constructor. """
return self._constructor(values=self._codes.copy(),
Expand Down Expand Up @@ -1977,6 +1981,10 @@ def __unicode__(self):

return result

def __repr__(self):
# We want PandasObject.__repr__, which dispatches to __unicode__
return super(ExtensionArray, self).__repr__()

def _maybe_coerce_indexer(self, indexer):
""" return an indexer coerced to the codes dtype """
if isinstance(indexer, np.ndarray) and indexer.dtype.kind == 'i':
Expand Down Expand Up @@ -2325,9 +2333,6 @@ def _concat_same_type(self, to_concat):

return _concat_categorical(to_concat)

def _formatting_values(self):
return self

def isin(self, values):
"""
Check whether `values` are contained in Categorical.
Expand Down
Loading