Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: DataFrame.loc/iloc fails to update object with new dtype GH24269 #24383

Closed
wants to merge 3 commits into from
Closed

BUG: DataFrame.loc/iloc fails to update object with new dtype GH24269 #24383

wants to merge 3 commits into from

Conversation

slnguyen
Copy link

@pep8speaks
Copy link

pep8speaks commented Dec 21, 2018 •
edited
Loading

Hello @slnguyen! Thanks for updating the PR.

Comment last updated on December 21, 2018 at 18:31 Hours UTC

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #24383 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24383      +/-   ##
==========================================
- Coverage   92.29%   92.29%   -0.01%     
==========================================
  Files         162      162              
  Lines       51845    51849       +4     
==========================================
+ Hits        47852    47855       +3     
- Misses       3993     3994       +1
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.98% <25%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexing.py 93.89% <100%> (+0.02%) ⬆️
pandas/util/testing.py 87.57% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a0eac...49df896. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #24383 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24383      +/-   ##
==========================================
+ Coverage   92.29%    92.3%   +<.01%     
==========================================
  Files         162      162              
  Lines       51845    51879      +34     
==========================================
+ Hits        47852    47888      +36     
+ Misses       3993     3991       -2
Flag Coverage Δ
#multiple 90.71% <100%> (ø) ⬆️
#single 42.98% <25%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexing.py 93.89% <100%> (+0.02%) ⬆️
pandas/core/generic.py 96.62% <0%> (-0.04%) ⬇️
pandas/core/indexes/datetimelike.py 97.28% <0%> (-0.01%) ⬇️
pandas/core/base.py 97.66% <0%> (ø) ⬆️
pandas/core/reshape/reshape.py 99.56% <0%> (ø) ⬆️
pandas/core/series.py 93.71% <0%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 96.51% <0%> (+0.06%) ⬆️
pandas/util/testing.py 87.84% <0%> (+0.18%) ⬆️
pandas/core/dtypes/concat.py 97.05% <0%> (+0.45%) ⬆️
pandas/compat/numpy/function.py 87.91% <0%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a0eac...1ea92e7. Read the comment docs.

@gfyoung gfyoung added Bug Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions labels Dec 23, 2018
@gfyoung
Copy link
Member

gfyoung commented Dec 23, 2018

@slnguyen : Good start! Going to need to add a new test + whatsnew entry as well.

jreback
jreback requested changes Dec 23, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first thing you need is a test, before any code changes. the indexing code is quite complicated.

pandas/core/indexing.py
@@ -630,6 +630,17 @@ def can_do_equal_len():
self.obj[item_labels[indexer[info_axis]]] = value
return

if isinstance(value, ABCDataFrame):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very complicated and likely does not belong here. you would need to heavily comment this and explain line by line.

@jreback
Copy link
Contributor

jreback commented Jan 14, 2019

closing as stale if you want to continue working, please ping.

@jreback jreback closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrame.loc/iloc fails to update object with new dtype
4 participants
@slnguyen @pep8speaks @gfyoung @jreback