CLN/TST: indexing/multiindex/test_getitem.py #24741
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24741 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52358 52358
=======================================
Hits 48373 48373
Misses 3985 3985
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24741 +/- ##
==========================================
+ Coverage 92.38% 92.39% +<.01%
==========================================
Files 166 166
Lines 52358 52358
==========================================
+ Hits 48373 48374 +1
+ Misses 3985 3984 -1
Continue to review full report at Codecov.
|
WillAyd
added
Testing
| @@ -15,6 +16,14 @@ def single_level_multiindex(): | |||
| codes=[[0, 1, 2, 3]], names=['first']) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def frame_random_data_integer_multi_index(): | |||
There was a problem hiding this comment.
Is this fixture duplicative of the one in conftest?
There was a problem hiding this comment.
@WillAyd : probably yes.. it is a dataframe with random data with an integer multi-level index, so multiindex_year_month_day_dataframe_random_data fixture could probably be used instead.
There was a problem hiding this comment.
OK - if you want to tackle that in a follow up always good to reduce duplication
| (pd.IndexSlice[:, ['foo']], True, None), | ||
| (pd.IndexSlice[:, ['foo', 'bah']], True, None) | ||
| ]) | ||
| def test_getitem_duplicates_multiindex_missing_indexers(indexer, is_level1, |
There was a problem hiding this comment.
I suppose it's better to rename these get_loc since that is in fact what they are testing
There was a problem hiding this comment.
@WillAyd agreed. this PR is cleaning up test_getitem.py after splitting and parametrizing. that task is still to do for test_loc.py so the renaming can be done in that cleanup.
There was a problem hiding this comment.
have renamed tests moved to test_loc.py to include loc_getitem
|
Thanks @simonjayhawkins keep them coming! |
follow-on from #24452 to add section breaks and move tests. also
KeyErrorchecks made more explicit.