Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25063 on branch 0.24.x (API: change Index set ops sort=True -> sort=None) #25083

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25063: API: change Index set ops sort=True -> sort=None

@lumberbot-app lumberbot-app bot added this to the 0.24.1 milestone Feb 1, 2019
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #25083 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25083      +/-   ##
==========================================
+ Coverage   92.36%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52398    52410      +12     
==========================================
+ Hits        48400    48416      +16     
+ Misses       3998     3994       -4
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 42.88% <57.69%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.6% <100%> (+0.01%) ⬆️
pandas/core/indexes/datetimes.py 96.27% <100%> (ø) ⬆️
pandas/core/indexes/api.py 99% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.55% <100%> (+0.22%) ⬆️
pandas/core/indexes/interval.py 95.25% <100%> (ø) ⬆️
pandas/core/indexes/range.py 97.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21d32f...570cabd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #25083 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25083      +/-   ##
==========================================
+ Coverage   92.36%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52398    52410      +12     
==========================================
+ Hits        48400    48416      +16     
+ Misses       3998     3994       -4
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 42.88% <57.69%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.6% <100%> (+0.01%) ⬆️
pandas/core/indexes/datetimes.py 96.27% <100%> (ø) ⬆️
pandas/core/indexes/api.py 99% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.55% <100%> (+0.22%) ⬆️
pandas/core/indexes/interval.py 95.25% <100%> (ø) ⬆️
pandas/core/indexes/range.py 97.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21d32f...570cabd. Read the comment docs.

@TomAugspurger TomAugspurger merged commit c24df00 into pandas-dev:0.24.x Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants