Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: fix incorrect sparse test (now failing on scipy master) #25653

Merged
merged 2 commits into from
Mar 11, 2019
Merged

TST: fix incorrect sparse test (now failing on scipy master) #25653

merged 2 commits into from
Mar 11, 2019

Conversation

jorisvandenbossche
Copy link
Member

Closes #25652

@TomAugspurger
Copy link
Contributor

Tagging this for backport.

@TomAugspurger TomAugspurger added this to the 0.24.2 milestone Mar 11, 2019
@TomAugspurger TomAugspurger added the CI Continuous Integration label Mar 11, 2019
@jorisvandenbossche
Copy link
Member Author

@TomAugspurger my first analysis was wrong. The failure was actually a bug fix in scipy, indicating at a wrong usage of coo_matrix. See updated version of this PR. For testing the result, I just assumed the current result of it on master is correct, but if you can take a quick look.

@jorisvandenbossche jorisvandenbossche changed the title TST: fix failing sparse test for scipy master TST: fix incorrect sparse test (now failing on scipy master) Mar 11, 2019
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 11, 2019
Closed
@pandas-dev pandas-dev deleted a comment from codecov bot Mar 11, 2019
@pandas-dev pandas-dev deleted a comment from codecov bot Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25653 into master will decrease coverage by 49.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25653       +/-   ##
===========================================
- Coverage   91.26%   41.71%   -49.55%     
===========================================
  Files         173      173               
  Lines       52968    52968               
===========================================
- Hits        48340    22096    -26244     
- Misses       4628    30872    +26244
Flag Coverage Δ
#multiple ?
#single 41.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f886139...e61d5a7. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #25653 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25653      +/-   ##
==========================================
- Coverage   91.26%   91.26%   -0.01%     
==========================================
  Files         173      173              
  Lines       52968    52968              
==========================================
- Hits        48340    48339       -1     
- Misses       4628     4629       +1
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.57% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f886139...e61d5a7. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

Not sure why it is not showing green (but still busy here), as on Azure everything is finished (https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=9255), so merging.

@jorisvandenbossche jorisvandenbossche merged commit 3dfb6d4 into pandas-dev:master Mar 11, 2019
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 11, 2019
@jorisvandenbossche
Backport PR pandas-dev#25653: TST: fix incorrect sparse test (now fai…
0f3988d 
…ling on scipy master)
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 11, 2019
Merged
TomAugspurger pushed a commit that referenced this pull request Mar 11, 2019
@meeseeksmachine @TomAugspurger
Backport PR #25653: TST: fix incorrect sparse test (now failing on sc…
7afa882 
…ipy master) (#25654)
thoo added a commit to thoo/pandas that referenced this pull request Mar 11, 2019
@thoo
Merge remote-tracking branch 'upstream/master' into pivot
aaa21bb 
* upstream/master: (110 commits)
  DOC: hardcode contributors for 0.24.x releases (pandas-dev#25662)
  DOC: restore toctree maxdepth (pandas-dev#25134)
  BUG: Redefine IndexOpsMixin.size, fix pandas-dev#25580. (pandas-dev#25584)
  BUG: to_csv line endings with compression (pandas-dev#25625)
  DOC: file obj for to_csv must be newline='' (pandas-dev#25624)
  Suppress incorrect warning in nargsort for timezone-aware DatetimeIndex (pandas-dev#25629)
  TST: fix incorrect sparse test (now failing on scipy master) (pandas-dev#25653)
  CLN: Removed debugging code (pandas-dev#25647)
  DOC: require Return section only if return is not None nor commentary (pandas-dev#25008)
  DOC:Remove hard-coded examples from _flex_doc_SERIES (pandas-dev#24589) (pandas-dev#25524)
  TST: xref pandas-dev#25630 (pandas-dev#25643)
  BUG: Fix pandas-dev#25481 by fixing the error message in TypeError (pandas-dev#25540)
  Fixturize tests/frame/test_mutate_columns.py (pandas-dev#25642)
  Fixturize tests/frame/test_join.py (pandas-dev#25639)
  Fixturize tests/frame/test_combine_concat.py (pandas-dev#25634)
  Fixturize tests/frame/test_asof.py (pandas-dev#25628)
  BUG: Fix user-facing AssertionError with to_html (pandas-dev#25608) (pandas-dev#25620)
  DOC: resolve all GL03 docstring validation errors (pandas-dev#25525)
  TST: failing wheel building on PY2 and old numpy (pandas-dev#25631)
  DOC: Remove makePanel from docs (pandas-dev#25609) (pandas-dev#25612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @TomAugspurger