Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #25625 on branch 0.24.x (BUG: to_csv line endings with compression) #25663

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Backport PR #25625 on branch 0.24.x (BUG: to_csv line endings with compression) #25663

merged 1 commit into from
Mar 11, 2019

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25625: BUG: to_csv line endings with compression

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Mar 11, 2019
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 11, 2019
Merged
@jreback jreback added the IO CSV read_csv, to_csv label Mar 11, 2019
@jorisvandenbossche jorisvandenbossche merged commit 0fa9580 into pandas-dev:0.24.x Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25663 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25663      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52424    52424              
==========================================
+ Hits        48436    48437       +1     
+ Misses       3988     3987       -1
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/common.py 72.86% <100%> (ø) ⬆️
pandas/util/testing.py 88.13% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fe1dc...f35fc7c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #25663 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25663      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52424    52424              
==========================================
+ Hits        48436    48437       +1     
+ Misses       3988     3987       -1
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/common.py 72.86% <100%> (ø) ⬆️
pandas/util/testing.py 88.13% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fe1dc...f35fc7c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
4 participants
@meeseeksmachine @jreback @jorisvandenbossche @chris-b1