Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy error in pandas/tests.indexes.test_base.py #29188

Merged
merged 14 commits into from
Nov 27, 2019
Merged

Fix mypy error in pandas/tests.indexes.test_base.py #29188

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bc67f66
solved type annotaiton problem
rushabh-v Oct 23, 2019
e7e1cab
Update setup.cfg
rushabh-v Oct 23, 2019
73d34ba
Update setup.cfg
rushabh-v Oct 25, 2019
fcddcfc
removed comment
rushabh-v Oct 25, 2019
08a5a54
Merge branch 'master' into master
simonjayhawkins Nov 13, 2019
0ac9cbb
Merge branch 'master' into master
rushabh-v Nov 18, 2019
27eef1e
merge branch master into 'master'
rushabh-v Nov 18, 2019
092e0d7
Update README.md
rushabh-v Nov 19, 2019
e6d7498
revert the last change
rushabh-v Nov 19, 2019
07cc23f
revert the mistake
rushabh-v Nov 19, 2019
32951cf
Add #type: ignore for the Slicing error
rushabh-v Nov 27, 2019
90bab5f
Merge branch 'mypy_test_base'
rushabh-v Nov 27, 2019
75d71a0
add spaces acc. to PEP 8
rushabh-v Nov 27, 2019
5599131
remove unwanted
rushabh-v Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions pandas/tests/indexes/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ def test_constructor_dtypes_timedelta(self, attr, klass):
result = klass(list(values), dtype=dtype)
tm.assert_index_equal(result, index)

@pytest.mark.parametrize("value", [[], iter([]), (x for x in [])])
@pytest.mark.parametrize("value", [[], iter([]), (_ for _ in [])])
@pytest.mark.parametrize(
"klass",
[
Expand All @@ -530,7 +530,7 @@ def test_constructor_empty(self, value, klass):
[
(PeriodIndex([], freq="B"), PeriodIndex),
(PeriodIndex(iter([]), freq="B"), PeriodIndex),
(PeriodIndex((x for x in []), freq="B"), PeriodIndex),
(PeriodIndex((_ for _ in []), freq="B"), PeriodIndex),
(RangeIndex(step=1), pd.RangeIndex),
(MultiIndex(levels=[[1, 2], ["blue", "red"]], codes=[[], []]), MultiIndex),
],
Expand Down Expand Up @@ -1732,23 +1732,23 @@ def test_slice_locs_na_raises(self):
@pytest.mark.parametrize(
"in_slice,expected",
[
(pd.IndexSlice[::-1], "yxdcb"),
(pd.IndexSlice["b":"y":-1], ""),
(pd.IndexSlice["b"::-1], "b"),
(pd.IndexSlice[:"b":-1], "yxdcb"),
(pd.IndexSlice[:"y":-1], "y"),
(pd.IndexSlice["y"::-1], "yxdcb"),
(pd.IndexSlice["y"::-4], "yb"),
(pd.IndexSlice[::-1], "yxdcb"), # type: ignore
rushabh-v marked this conversation as resolved.
Show resolved Hide resolved
(pd.IndexSlice["b":"y":-1], ""), # type: ignore
(pd.IndexSlice["b"::-1], "b"), # type: ignore
(pd.IndexSlice[:"b":-1], "yxdcb"), # type: ignore
(pd.IndexSlice[:"y":-1], "y"), # type: ignore
(pd.IndexSlice["y"::-1], "yxdcb"), # type: ignore
(pd.IndexSlice["y"::-4], "yb"), # type: ignore
# absent labels
(pd.IndexSlice[:"a":-1], "yxdcb"),
(pd.IndexSlice[:"a":-2], "ydb"),
(pd.IndexSlice["z"::-1], "yxdcb"),
(pd.IndexSlice["z"::-3], "yc"),
(pd.IndexSlice["m"::-1], "dcb"),
(pd.IndexSlice[:"m":-1], "yx"),
(pd.IndexSlice["a":"a":-1], ""),
(pd.IndexSlice["z":"z":-1], ""),
(pd.IndexSlice["m":"m":-1], ""),
(pd.IndexSlice[:"a":-1], "yxdcb"), # type: ignore
(pd.IndexSlice[:"a":-2], "ydb"), # type: ignore
(pd.IndexSlice["z"::-1], "yxdcb"), # type: ignore
(pd.IndexSlice["z"::-3], "yc"), # type: ignore
(pd.IndexSlice["m"::-1], "dcb"), # type: ignore
(pd.IndexSlice[:"m":-1], "yx"), # type: ignore
(pd.IndexSlice["a":"a":-1], ""), # type: ignore
(pd.IndexSlice["z":"z":-1], ""), # type: ignore
(pd.IndexSlice["m":"m":-1], ""), # type: ignore
],
)
def test_slice_locs_negative_step(self, in_slice, expected):
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@ ignore_errors=True
[mypy-pandas.tests.indexes.datetimes.test_tools]
ignore_errors=True

[mypy-pandas.tests.indexes.test_base]
ignore_errors=True

[mypy-pandas.tests.scalar.period.test_period]
ignore_errors=True

Expand Down