Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: implement cumulative ops block-wise #29872

Merged
merged 10 commits into from
Dec 30, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

cc @TomAugspurger

pandas/core/internals/managers.py Outdated Show resolved Hide resolved
pandas/core/generic.py Show resolved Hide resolved
@WillAyd WillAyd added the Internals Related to non-user accessible pandas implementation label Nov 27, 2019
pandas/core/generic.py Show resolved Hide resolved
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Would be good to have a release note and some tests that exercise this directly.

pandas/core/generic.py Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

ok with moving this later, does this need a whatsnew note / additional tests as @TomAugspurger asks?

@jbrockmendel
Copy link
Member Author

does this need a whatsnew note / additional tests as

So far i haven't been able to write tests that fail without this. Haven't given up.

@jreback jreback added this to the 1.0 milestone Dec 27, 2019
@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

do @TomAugspurger original tests work on master?

@jbrockmendel
Copy link
Member Author

do @TomAugspurger original tests work on master?

good point! no, but they work here. will update

@pep8speaks
Copy link

pep8speaks commented Dec 27, 2019

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-27 20:23:03 UTC

@jbrockmendel
Copy link
Member Author

same unrelated-looking docbuild failure as #29847. im guessing this is going to be affecting all PRs about now, will take a look

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go.

@jreback jreback merged commit db062da into pandas-dev:master Dec 30, 2019
@jreback
Copy link
Contributor

jreback commented Dec 30, 2019

thanks, looking forward to the cleanups!

@jbrockmendel jbrockmendel deleted the accum branch December 30, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cumulative Methods with mixed frames casts to object
5 participants