Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: x.__class__ to type(x) #batch-5 #29904

Merged

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 27, 2019

@ShaharNaveh ShaharNaveh force-pushed the STY-dunderClasss-to-type-batch-5 branch from 9b83f40 to ad40b62 Compare November 27, 2019 22:44
@alimcmaster1 alimcmaster1 added the Code Style Code style, linting, code_checks label Nov 27, 2019
@alimcmaster1 alimcmaster1 added this to the 1.0 milestone Nov 27, 2019
@alimcmaster1
Copy link
Member

Thanks for the PR @MomIsBestFriend ! Do we have an issue for this btw? Ref just seems to be to a PR?

@ShaharNaveh
Copy link
Member Author

Thanks for the PR @MomIsBestFriend ! Do we have an issue for this btw? Ref just seems to be to a PR?

No we don't have an issue for that, it's something that was mentioned here, And I decided to take care of it.

@WillAyd WillAyd merged commit dbae240 into pandas-dev:master Nov 29, 2019
@ShaharNaveh ShaharNaveh deleted the STY-dunderClasss-to-type-batch-5 branch November 30, 2019 10:12
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants