Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: x.__class__ to type(x) #batch-6 #29905

Merged
merged 2 commits into from
Nov 29, 2019
Merged

STY: x.__class__ to type(x) #batch-6 #29905

merged 2 commits into from
Nov 29, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 27, 2019 •
edited
Loading

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Nov 27, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Nov 27, 2019
alimcmaster1
alimcmaster1 requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - minor comments

pandas/util/testing.py Outdated Show resolved Hide resolved
@WillAyd WillAyd merged commit 878d319 into pandas-dev:master Nov 29, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 29, 2019

Thanks @MomIsBestFriend - is that all of the remaining ones? If so can you add a code check in a follow up PR?

@ShaharNaveh ShaharNaveh deleted the STY-dunderClasss-to-type-batch-6 branch November 30, 2019 10:12
@ShaharNaveh ShaharNaveh mentioned this pull request Nov 30, 2019
Merged
5 tasks
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: x.__class__ to type(x) #batch-6 (pandas-dev#29905)
968beb1
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: x.__class__ to type(x) #batch-6 (pandas-dev#29905)
e3c6244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 requested changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @WillAyd @alimcmaster1 @simonjayhawkins