Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: fstrings, repr pandas/io/html.py #30093

Merged
merged 2 commits into from
Dec 8, 2019
Merged

STY: fstrings, repr pandas/io/html.py #30093

merged 2 commits into from
Dec 8, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 5, 2019 •
edited
Loading

@alimcmaster1 alimcmaster1 added Code Style Code style, linting, code_checks Clean labels Dec 5, 2019
@alimcmaster1 alimcmaster1 reopened this Dec 5, 2019
@alimcmaster1
Copy link
Member

Kicking off CI again - its this test. #30031

alimcmaster1
alimcmaster1 approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaharNaveh
Copy link
Member Author

@alimcmaster1 Travis passed before, right?

Is there anything wrong with the changes? any suggestions?

@alimcmaster1
Copy link
Member

Looks like a segfault on the travis run unrelated to your changes @MomIsBestFriend

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 6, 2019
@jreback jreback merged commit a809b3a into pandas-dev:master Dec 8, 2019
@jreback
Copy link
Contributor

jreback commented Dec 8, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the STY-fstrings-io-html branch December 8, 2019 21:09
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: fstrings, repr (pandas-dev#30093)
24d9bef
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: fstrings, repr (pandas-dev#30093)
7f8d4b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @alimcmaster1 @jreback @simonjayhawkins