Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: replace str.format() in pandas/io/formats #30230

Closed
wants to merge 3 commits into from
Closed

CLN: replace str.format() in pandas/io/formats #30230

wants to merge 3 commits into from

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Dec 12, 2019 •
edited
Loading

@lithomas1 lithomas1 changed the title CLN: replace str.format() and !r in pandas/io/formats CLN: replace str.format() in pandas/io/formats Dec 12, 2019
@TomAugspurger
Copy link
Contributor

Merging master should fix the CI issues.

simonjayhawkins
simonjayhawkins reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lithomas1 for the PR. couple of suggestions otherwise lgtm.

pandas/io/formats/style.py Outdated Show resolved Hide resolved
pandas/io/formats/excel.py Outdated Show resolved Hide resolved
pandas/io/formats/excel.py Outdated Show resolved Hide resolved
@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Dec 12, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 12, 2019
WillAyd
WillAyd approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm outside of suggestions from @simonjayhawkins

@lithomas1 @simonjayhawkins
Apply suggestions from code review
6ed6828 
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
@lithomas1 lithomas1 closed this Dec 13, 2019
@lithomas1 lithomas1 deleted the cln-fstring branch December 13, 2019 00:37
@lithomas1 lithomas1 mentioned this pull request Dec 13, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lithomas1 @TomAugspurger @WillAyd @simonjayhawkins