Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pandas/tests/indexes/datetimes/test_ops.py to utilize python3 … #30420

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

AncientRickles
Copy link
Contributor

@AncientRickles AncientRickles commented Dec 23, 2019

Updated pandas/tests/indexes/datetimes/test_ops.py to utilize python3 format strings. Ran the test and it seems good. I moved the msg into the for loop because it seems cleaner with the new format string logic.
ref #29886 and #29547.

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Dec 23, 2019
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WillAyd WillAyd merged commit 6df408b into pandas-dev:master Dec 23, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 23, 2019

Thanks @AncientRickles

AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants