Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Insert 'match' to bare pytest raises #30997

Merged
merged 9 commits into from
Jan 14, 2020
Merged

TST: Insert 'match' to bare pytest raises #30997

merged 9 commits into from
Jan 14, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 14, 2020 •
edited
Loading

simonjayhawkins
simonjayhawkins reviewed Jan 14, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend for the PR.

pandas/tests/test_take.py Outdated Show resolved Hide resolved
@simonjayhawkins simonjayhawkins added Clean Testing pandas testing functions or related to the test suite labels Jan 14, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 14, 2020
@ShaharNaveh @simonjayhawkins
Update pandas/tests/test_take.py
8155b3b 
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
@ShaharNaveh
Copy link
Member Author

@simonjayhawkins Do you mind if I open a master issue, instead of #23922 ?
There's a lot of noise there about how to find a bare pytest raises, I have a test case and I can point at the line number at each file with a bare pytest raise, and will make a list of occurrences (similar to #29886)

Do you think it's a good idea?

@simonjayhawkins
Copy link
Member

Do you think it's a good idea?

The format of #29886 worked well for community engagement. so OK with opening a new issue to supersede #23922.

simonjayhawkins
simonjayhawkins approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend lgtm pending green.

WillAyd
WillAyd requested changes Jan 14, 2020
View reviewed changes
pandas/tests/test_lib.py Outdated Show resolved Hide resolved
@jbrockmendel
Copy link
Member

pending addressing comments from @WillAyd, LGTM

@simonjayhawkins simonjayhawkins merged commit 8d093fe into pandas-dev:master Jan 14, 2020
@simonjayhawkins
Copy link
Member

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the TST-bare-pytest-raises branch January 15, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @simonjayhawkins @jbrockmendel @WillAyd