BUG: objToJson.c - fix return value #31482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to not work on mac:
|
|
Not at a computer to check but just might want to return NULL at the end of the function instead of changing it from a void pointer to void. I think original error is that the import_array() macro may only return that in some versions, so can force to work for all by returning NULL (though also a little strange) |
|
Thanks Will - confirmed we no longer see the below warnings with this change. |
alimcmaster1
changed the title
jreback
requested changes
Feb 1, 2020
There was a problem hiding this comment.
@alimcmaster1 can you add a note in the whatsnew (1.0.1), ping on green.
jreback
approved these changes
Feb 2, 2020
|
thanks @alimcmaster1 ping on green (ex the 37 build which i just have to backport to CI). |
|
thanks @alimcmaster1 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 2, 2020
jreback
pushed a commit
that referenced
this pull request
Feb 2, 2020
Co-authored-by: alimcmaster1 <alimcmaster1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=27217&view=logs&j=3a03f79d-0b41-5610-1aa4-b4a014d0bc70&t=fe74a338-551b-5fbb-553d-25f48b1836e8&l=687
Seems like this warning is somehow causing an error in the users builds of pandas