CI: Remove warning raising after new matplotlib release #31573
Conversation
|
xref #30588 |
| import matplotlib as mpl | ||
|
|
||
| version = mpl.__version__ | ||
| if version > "3.1.2": |
There was a problem hiding this comment.
can also just define a new mpl skip decorator and skip if < 3.1.2
There was a problem hiding this comment.
thanks for your quick reply, changed, and let me know if this is what you meant @jreback
| @@ -59,16 +60,15 @@ def test_register_by_default(self): | |||
| call = [sys.executable, "-c", code] | |||
| assert subprocess.check_call(call) == 0 | |||
|
|
|||
| @td.skip_if_low_mpl | |||
There was a problem hiding this comment.
yes right idea
i think we have some skips that are based on mpl versions already (maybe in the other test plotting files)
can u name like them
There was a problem hiding this comment.
emm, i see we have skip_if_no_mpl and skip_if_mpl decorators, but seems no version involved.
There was a problem hiding this comment.
does skip_if_old_mpl sound better? or skip_if_lower_3_1_2_mpl?
|
Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-02 16:12:22 UTC |
| @@ -91,6 +91,7 @@ def test_matplotlib_formatters(self): | |||
| assert Timestamp not in units.registry | |||
| assert Timestamp in units.registry | |||
|
|
|||
| @td.skip_if_lower_3_1_2_mpl | |||
There was a problem hiding this comment.
sorry we don't really want to add this as a full decorator, just do this
@td.skip_if_no("matplotlib", min_version="3.1.2")
|
this looks better simpler, i didn't notice this since it uses |
|
ping @jreback |
|
thanks for pro-actively fixing this @charlesdong1991 ! |
…tplotlib release
…elease (#31576) Co-authored-by: Kaiqi Dong <kaiqidong1991@gmail.com>
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffseems CI is broken after the new release of matplotlib