REF: remove BlockManager.set #33347
Merged
REF: remove BlockManager.set #33347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/generic.py
Outdated
| @@ -3210,7 +3210,7 @@ def _maybe_cache_changed(self, item, value) -> None: | |||
| """ | |||
| The object has called back to us saying maybe it has changed. | |||
| """ | |||
| self._mgr.set(item, value) | |||
| NDFrame._set_item(self, item, value, clear=False) | |||
There was a problem hiding this comment.
for my edification, why NDFrame?
There was a problem hiding this comment.
because we dont want to go through the DataFrame._set_item method
There was a problem hiding this comment.
are double underscore methods appropriate here for intraclass method calls? https://docs.python.org/3/tutorial/classes.html?highlight=mangle#private-variables
jbrockmendel
added
Internals
jreback
reviewed
Apr 15, 2020
pandas/core/generic.py
Outdated
| @@ -3589,13 +3589,20 @@ def _slice(self: FrameOrSeries, slobj: slice, axis=0) -> FrameOrSeries: | |||
| result._set_is_copy(self, copy=is_copy) | |||
| return result | |||
|
|
|||
| def _iset_item(self, loc: int, value) -> None: | |||
| def _iset_item(self, loc: int, value, clear: bool_t = True) -> None: | |||
There was a problem hiding this comment.
we get here via NDFrame._maybe_cache_changed.
These are pretty spaghetti-ish, looking forward to cleaning them out
|
updated to remove the need for |
|
thanks! |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #33052, #33332.
This touches several DataFrame/NDFrame methods. Those methods need a refactor in part because the ones defined on NDFrame are only ever called for DataFrame. Will refactor in follow-up.