BUG: fix construction from read-only non-ns datetime64 numpy array #34844
Conversation
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -843,6 +843,9 @@ Datetimelike | |||
| - Bug in :meth:`DatetimeIndex.intersection` and :meth:`TimedeltaIndex.intersection` with results not having the correct ``name`` attribute (:issue:`33904`) | |||
| - Bug in :meth:`DatetimeArray.__setitem__`, :meth:`TimedeltaArray.__setitem__`, :meth:`PeriodArray.__setitem__` incorrectly allowing values with ``int64`` dtype to be silently cast (:issue:`33717`) | |||
| - Bug in subtracting :class:`TimedeltaIndex` from :class:`Period` incorrectly raising ``TypeError`` in some cases where it should succeed and ``IncompatibleFrequency`` in some cases where it should raise ``TypeError`` (:issue:`33883`) | |||
| - Bug in constructing a Series or Index from a read-only numpy array with non-ns | |||
There was a problem hiding this comment.
:class: for Series and Index? numpy -> NumPy?
| @@ -145,3 +158,14 @@ def test_constructor_datetime_outofbound(self, a, klass): | |||
| msg = "Out of bounds" | |||
| with pytest.raises(pd.errors.OutOfBoundsDatetime, match=msg): | |||
| klass(a, dtype="datetime64[ns]") | |||
|
|
|||
| def test_constructor_datetime_nonns(self, constructor): | |||
There was a problem hiding this comment.
See a few lines below
|
Travis failure are the numpy dev warnings |
| @@ -13,6 +13,19 @@ | |||
| from pandas.core.base import NoNewAttributesMixin, PandasObject | |||
|
|
|||
|
|
|||
| @pytest.fixture( | |||
There was a problem hiding this comment.
@jorisvandenbossche if you hadn’t merged this so quickly i would have objected here
creating this fixture for a single use is not that great
we typically also call this klass and don’t much care about dataframe-dict here
There are several existing occurrences of a "constructor" fixture, already
We actually do, as the test above has an xfail because
Yeah, that is because I first wanted to share it with the other existing test. But because that has an xfail on one of the fixture parameters, making it difficult to share. Once that bug is fixed, it can be shared though. |
Which is #26919 |
Closes #34843